Point the PKGBUILD at the current repo and release - #23
Open
nfvelten wants to merge 1 commit into
Open
Conversation
The packaged url still named basecamp/ttfx, which 404s since the move to
omacom/ttfx. Because source= is built from $url, makepkg failed at the
download step for anyone following the repo's own packaging instructions.
Fixing the url alone is not enough: pkgver was pinned to 0.1.0, six
releases behind the 0.3.2 tag, so a corrected url would still have
fetched a stale tarball. Both move together here.
Also replaces sha256sums=('SKIP') with the real digest of the 0.3.2
archive, so the downloaded tarball is actually verified.
Fixes omacom#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
packaging/PKGBUILDhad rotted in three ways, and they only work as a set:url="https://github.com/basecamp/ttfx"— 404s since the move toomacom.source=interpolates$url, so this is the download failure reported in Invalid url in PKGBUILD #21.pkgver=0.1.0— six releases behindv0.3.2. Correcting the url alone still fetches a stale tarball, so this had to move too.sha256sums=('SKIP')— the downloaded release tarball was never verified. Now carries the real digest.Nothing else changed;
build(),check()andpackage()were already correct at 0.3.2.Testing
makepkg -fon Arch, from a clean directory:cargo test --release --lockedpasses incheck(). The resulting package containsusr/bin/ttfx, the README and both completion files, and the binary reportsttfx 0.3.2.Two negative checks, so the diff is not just cosmetic:
urltobasecamp(keepingpkgver=0.3.2) still fails withcurl: (22) ... 404— the url fix is necessaryttfx-0.3.2.tar.gz ... FAILED— the digest is actually enforcedNotes
pkgverwill drift again on every release. Release binaries #20 (release binaries) plus a release workflow would let this consume real assets instead of/archive/tarballs, which is also the durable answer to the checksum caveat — GitHub's generated archives are not contractually byte-stable. Left out of this PR deliberately.arch=('x86_64')still excludesaarch64. I have no aarch64 machine to test on, so I left it alone.