BUG Fix: use HTML value to replace HTML

[JoshuaFortriede]

The original code used the text value of the element when replacing within the HTML. This causes problems when the value contains symbols such as "&" or ">". In these cases .text() != .html(). As such, the replacement won't work.

For instance, if I have a key of "Stain" and a value of "Hematoxylin & Eosin", the .text() of the value is "Hematoxylin & Eosin", but the .html() is "Hematoxylin & Eosin". As such running the replace will not work, and thus will not create the MAPR url.

Note: I do not believe this is the best fix. I think a cleaner approach is to rebuild the HTML entirely in coordination with the iconify function, but that is a bigger refactor.

[will-moore]

Hi @JoshuaFortriede - thanks for the PR.
I wonder if you could exclude all the JavaScript linting changes from your commit? I know it can be annoying to have badly formatted code, but it's impossible to see where you made the fix.

It also partly obscures the commit/blame history of the file.

If you want to re-format the file in a follow-up commit, perhaps you can add that commit to a file as described in https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/
(and https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view)

Thanks

[JoshuaFortriede]

Yes, sorry about that. I saved without my linting and the new commit is there.

[will-moore]

Thanks for that.

Since _valHTML is the same as $chvalue.html(), this is equivalent to

_valHTML.replace(_valHTML, '<a href="' + _url + '">' + _val + '</a>')

which is equivalent to

'<a href="' + _url + '">' + _val + '</a>'

Maybe I'm just missing something in the reading of this (without running it)?

I need to get omero-mapr set up on our test server so we can test this and #98..