activities panel word break

[will-moore]

Fixes #377.

To test:

• Need to run a script that has a very long message, with no spaces or even -.
• E.g. rename an Image with a very long name (alpha-numeric and _ only). Then choose this image for Batch_Image_Export script
• The Activities dialog shouldn't appear broken (see screenshots on Hidden download button in "Activities" #377).

[pwalczysko]

I do not seem to be able to run Batch_image_export script on merge-ci, user-3 Dataset https://merge-ci.openmicroscopy.org/web/webclient/?show=dataset-6473

Rerunning https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-server/ - maybe it will help

[pwalczysko]

Restart of the server did not help cc @sbesson

[sbesson]

I suspect it's related to ome/openmicroscopy#6325 (comment). Should we exclude and rebuild to confirm?

[pwalczysko]

I suspect it's related to ome/openmicroscopy#6325 (comment). Should we exclude and rebuild to confirm?

I have added --exclude to the description of ome/openmicroscopy#6325 (comment) and rerun the https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-server/ but this did not help. Maybe another job needs to be rerun, which takes into account a new merge of PRs ?

Edit: added an Exclude label and rerunning the job. Maybe that will do it.

[sbesson]

Correct, the builds need to rebuild the server without the PR first. I relaunched the suite of jobs from the OMERO distribution step

[pwalczysko]

Thank you @sbesson , now the scripts work.

[pwalczysko]

@will-moore

Batch image export script is failing on the long name itself. See below

Traceback (most recent call last):
  File "./script", line 625, in <module>
    run_script()
  File "./script", line 609, in run_script
    file_annotation, message = batch_image_export(conn, script_params)
  File "./script", line 451, in batch_image_export
    folder_name=folder_name)
  File "./script", line 257, in save_planes_for_image
    c, g_scale, zoom_percent, folder_name)
  File "./script", line 144, in save_plane
    plane.save(img_name)
  File "/home/omero/workspace/OMERO-server/.venv3/lib64/python3.6/site-packages/PIL/Image.py", line 2237, in save
    fp = builtins.open(filename, "w+b")
OSError: [Errno 36] File name too long: 'Batch_Image_Export/BFdownloads6for777BFPackage_xxxxxxxxxxxuuuuuuuuuuuuqqWWWWWWWblahblahjdksjafldjoujewoiruwoiegoiwhqajogvjasdfohaweohfohwofhowqhfouhqwofuhqwfghwpqhgouqwhgouhwqughquwhgopuqwhguqhwgouhqwughqwugfhiuqwhgouqhwgouhqwgouhqwughqwghaqiwhguqwghuiqghuiqwhiugfh.png_merged_z01_t01.jpg'

Batch_image_export script on merge-ci, user-3 Dataset https://merge-ci.openmicroscopy.org/web/webclient/?show=dataset-6473

[will-moore]

Test with this image is working: https://merge-ci.openmicroscopy.org/web/webclient/?show=image-242242 (user-3)

[pwalczysko]

Works as expected when another script (not the Batch Image Export) is used.
The error on Batch Image Export is coming from python, and is unrelated to the fix in this PR.

Ready to merge fmpov.