feat: add full-loop fixed-factor Brunet APIs - #2
Open
LCGaoZzz wants to merge 1 commit into
Open
Conversation
LCGaoZzz
marked this pull request as ready for review
August 2, 2026 04:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class full-loop fixed-factor Brunet/KL APIs for Spatial EcoTyper training and projection.
Root cause
The downstream LOOCV workflow previously crossed the Python/PyO3 boundary once per NMF iteration and rebuilt invariant transposes and sums repeatedly. A formal 20-repeat, 6-sample workflow performs many projection solves, so that call overhead and repeated setup dominated runtime and made thread budgeting difficult to attest.
Changes
fixed_h_brunetandfixed_w_brunetpublic Python APIs;stable > stopconvstopping (default first stop at iteration 420);V > 0 && WH == 0;Validation
cargo test --release --manifest-path rust/Cargo.toml --lib: 7 passedpython -m pytest tests -q: 26 passedDownstream integration: PrimorDecode/omicos-admin#454.