Localization readiness (i18n) for all user-facing strings#185
Merged
Conversation
|
@Aditya8369 is attempting to deploy a commit to the Om Roy's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localization readiness (i18n) groundwork has been added and the major user-facing strings in notifications + weekly report have been refactored to use a localization layer.
Implemented:
Added locales/en.json with i18n keys for notifications + weekly report UI/text.
Added i18n.js providing window.i18n.t(key, params) plus language persistence via localStorage (learnsphere_lang).
Updated notifications.js to replace hardcoded UI and milestone notification strings with t(...) lookups.
Updated weeklyReport.js to replace hardcoded UI and summary text with t(...) lookups.
Added optional _t integration in quizProgress.js and replaced the milestone notification strings there with i18n keys.
closes #167