Notifications reliability: dedupe + delivery state#191
Merged
Conversation
|
@Aditya8369 is attempting to deploy a commit to the Om Roy's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have successfully implemented the requested notifications reliability features:
Storage Robustness: Handled environment fallback checks in loadStore and saveStore using a synchronized inMemoryStore to prevent crashes when running under testing/headless environments where localStorage is missing or limited.
Deduplication on Receipt: Pushed notifications now deduplicate automatically based on explicit ID matching, matching dedupeKey within a 24-hour window, and duplicate title/message content within a 60-second window.
Delivery Tracking: Every notification starts as "pending" and switches to "delivered" with a timestamp when loaded/rendered in the UI panel.
Explicit Acknowledgment: Cleaned up stale badge count behavior by marking notifications as read explicitly when a user clicks the "Open" CTA link or clicks the notification card itself.
Testing & Bundling: Implemented a comprehensive test suite in
notifications.test.js
(all 25 tests pass successfully) and verified Vite production bundling compiles without issues.
closes #173