feat(cfl): global search scope, positive limit validation, page view --full (#455) - #464
Merged
Conversation
# Conflicts: # skills/Confluence/CliReference.md # skills/Confluence/SKILL.md
# Conflicts: # skills/Confluence/SKILL.md
# Conflicts: # tools/cfl/internal/cmd/OUTPUT_SPEC.md # tools/cfl/internal/cmd/page/view.go # tools/cfl/internal/cmd/root/root.go
![rianjs-bot[bot]](https://avatars.githubusercontent.com/u/7378790?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 655b85c00bd7
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| documentation:docs | 0 |
| structure:repo-health | 0 |
Reviewer Coverage
| Reviewer | Status | Inspected | Skipped | Constraints |
|---|---|---|---|---|
| go:implementation-tests | complete_broad | tools/cfl/api/pages.go, tools/cfl/api/pages_test.go, tools/cfl/api/search.go, tools/cfl/api/search_test.go, tools/cfl/internal/cmd/attachment/list.go, tools/cfl/internal/cmd/attachment/list_test.go, tools/cfl/internal/cmd/page/view.go, tools/cfl/internal/cmd/page/view_test.go, tools/cfl/internal/cmd/root/root.go, tools/cfl/internal/cmd/root/root_test.go, tools/cfl/internal/cmd/search/search.go, tools/cfl/internal/cmd/search/search_test.go, tools/cfl/internal/pageview/projection.go, tools/cfl/internal/present/detail.go, tools/cfl/internal/present/detail_test.go | unavailable | The sandbox prevents httptest listeners and the default cgo build path fails due to spaces in the workspace path. Changed packages compile with CGO_ENABLED=0; pageview and present tests pass. |
| policies:conventions | complete_broad | README.md, docs/ARTIFACT_CONTRACT.md, tools/cfl/README.md, tools/cfl/internal/cmd/OUTPUT_SPEC.md, tools/cfl/internal/cmd/attachment/list.go, tools/cfl/internal/cmd/page/view.go, tools/cfl/internal/cmd/root/root.go, tools/cfl/internal/cmd/search/search.go | unavailable | Shared cli-common convention documents were not present locally; review used the repository-local development, artifact, architecture, and cfl output-contract documentation. |
| documentation:docs | complete_broad | README.md, docs/ARTIFACT_CONTRACT.md, skills/Confluence/CliReference.md, skills/Confluence/SKILL.md, skills/Confluence/Workflows/ManageAttachments.md, skills/Confluence/Workflows/SearchPages.md, skills/Confluence/Workflows/ViewPage.md, tools/cfl/CHANGELOG.md, tools/cfl/README.md, tools/cfl/internal/cmd/OUTPUT_SPEC.md | unavailable | Reviewed documentation against the changed local CLI implementation; no live Confluence service verification was needed. |
| structure:repo-health | complete_broad | tools/cfl/api/pages.go, tools/cfl/api/search.go, tools/cfl/internal/cmd/attachment/list.go, tools/cfl/internal/cmd/page/view.go, tools/cfl/internal/cmd/root/root.go, tools/cfl/internal/cmd/search/search.go, tools/cfl/internal/pageview/projection.go, tools/cfl/internal/present/detail.go | unavailable | Review limited to the eight assigned implementation files and their directly relevant contracts/tests. Targeted Go tests could not complete because the environment's compiler invocation fails on the workspace path, which contains spaces. |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 2m 12s | unavailable | gpt-5.6-terra | cr 0.10.260
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | go:implementation-tests, policies:conventions, documentation:docs, structure:repo-health |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 2m 12s wall · 6m 07s compute |
| Cost | unavailable |
| Tokens | 1.7M in / 16.0k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | gpt-5.6-terra | 16.1k | 637 | 10.5k | unavailable | unavailable | 14s |
| go:implementation-tests | gpt-5.6-terra | 585.3k | 4.0k | 519.7k | unavailable | unavailable | 1m 44s |
| policies:conventions | gpt-5.6-terra | 182.6k | 2.2k | 143.9k | unavailable | unavailable | 57s |
| documentation:docs | gpt-5.6-terra | 420.5k | 4.6k | 351.5k | unavailable | unavailable | 1m 36s |
| structure:repo-health | gpt-5.6-terra | 412.1k | 3.8k | 362.5k | unavailable | unavailable | 1m 30s |
| orchestrator-rollup | gpt-5.6-terra | 35.0k | 678 | 26.1k | unavailable | unavailable | 3s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #462, which was auto-closed when its base branch (
455-cfl-body-format) was deleted after the #459 squash-merge. Branch has been reconciled with main; content is identical plus reconciliation fixes.Implements issue #455 items 6, 8, 9:
cfl searchis global unless--spaceis explicit; configureddefault_spaceno longer silently scopes searches. Raw--cqlis mutually exclusive with the positional query and all builder flags.--limitonsearchandattachment listmust be a positive integer;--limit 0and negatives are rejected at the command layer.page view --full: adds parent ID, creation time, and author ID when present; composes with every--body-format; incompatible with--content-onlyand--web; commands without a defined full artifact reject--full.Docs updated across README, OUTPUT_SPEC, ARTIFACT_CONTRACT, and skills/Confluence. All prior review findings from #462 are already addressed on this branch.