Skip to content

[wip] Forward compatibility for definition schema - #1422

Draft
lmolkova wants to merge 4 commits into
open-telemetry:mainfrom
lmolkova:def-forward-compat
Draft

[wip] Forward compatibility for definition schema#1422
lmolkova wants to merge 4 commits into
open-telemetry:mainfrom
lmolkova:def-forward-compat

Conversation

@lmolkova

@lmolkova lmolkova commented May 7, 2026

Copy link
Copy Markdown
Member

This is stacked on #1365, delta: ad407f4

Changes:

  • add unexpected field detection in definition schema (always log warn on unknown ones with file_format: definition/2)
  • add support for definition/2.{x} format, make behavior consistent with resolved/manifest (fail on unknown when minor version is known, log-warn on future).

@lmolkova
lmolkova requested a review from a team as a code owner May 7, 2026 17:10
@lmolkova
lmolkova marked this pull request as draft May 7, 2026 17:10
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.18605% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.8%. Comparing base (2a09a07) to head (ad407f4).
⚠️ Report is 159 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_semconv/tests/forward_compat.rs 88.4% 6 Missing ⚠️
crates/weaver_semconv/src/manifest.rs 83.3% 4 Missing ⚠️
crates/weaver_semconv/src/unexpected_fields.rs 92.0% 4 Missing ⚠️
crates/weaver_resolver/src/loader.rs 85.7% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1422     +/-   ##
=======================================
+ Coverage   82.4%   82.8%   +0.3%     
=======================================
  Files        120     128      +8     
  Lines      10111   10701    +590     
=======================================
+ Hits        8336    8865    +529     
- Misses      1775    1836     +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 18, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-07-31 13:36 UTC

Move out of draft to request review.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant