fix(live-check): findings on resource samples carry resource attributes - #1612
Open
fabiovincenzi wants to merge 3 commits into
Open
fix(live-check): findings on resource samples carry resource attributes#1612fabiovincenzi wants to merge 3 commits into
fabiovincenzi wants to merge 3 commits into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-04 14:26 UTC Review the latest changes. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Findings on resource-level attributes are emitted (via
--emit-otlp-logs) withnone of the source resource's attributes, while findings on span/metric/log
samples correctly carry them.
Sample::resource()returnsNonefor aSample::Resource: it only returns asample's parent resource, and a resource has no parent.
Fix
Make a resource sample its own resource.
The only other callers are
sample_log.rsandsample_metric.rs, and both onlyever run on log/metric samples, so this doesn't change anything for them.
Testing
Unit tests covering: a resource sample is its own resource, span samples still
return their parent resource, samples without one still return
None, and theemit path flattens a resource sample's attributes into a finding.
Without the fix these fail with
left: None, right: Some("my-test-service").