resolver: fix provenance and resolution of attributes inherited from dependencies

[lmolkova]

Related to #1658

1. Provenance was lost on attributes inherited through a refinement

# b/main.yaml — b depends on a, refines a's metric
metric_refinements:
  - id: b.refined
    ref: a.metric
    brief: refined

  # b's resolved.yaml
  attribute_catalog:
  - key: foo
    brief: the foo
+   provenance:
+     source: 0      # → a

2. A bare ref resolved against the refinement's own copy

# c/main.yaml — refines b.metric, and has its own metric
metric_refinements:
  - id: c.refined
    ref: b.metric
    attributes:
      - ref: foo
        brief: foo as used by c     # signal-local wording
metrics:
  - name: c.metric
    attributes:
      - ref: foo                    # unrelated metric

  - name: c.metric
    attributes:
-   - base: 0        # brief: foo as used by c
+   - base: 1        # brief: the foo

3. A dependency re-exported an attribute it never defined, as its own

# b/main.yaml — b defines nothing, only refines
metric_refinements:
  - id: b.refined
    ref: a.metric

# c/main.yaml — c depends on b only
metrics:
  - name: c.metric
    attributes:
      - ref: foo

  # c's resolved.yaml
- - key: foo
-   provenance:
-     source: 1      # ← b, but a defines it
+ × attribute reference is not resolved: foo

Case 3 only happened when the dependency was consumed from source; a published one already refused. Now both behave the same.

[opentelemetry-pr-dashboard]

Pull request dashboard status

Waiting on the author · refreshed 2026-08-05 05:17 UTC

Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):

• Inline threads: 1

Status above doesn't look right?

• Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
• Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
• Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

[codecov]

Codecov Report

❌ Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (f7b63a0) to head (6e7792c).

Files with missing lines	Patch %	Lines
crates/weaver_resolver/src/attribute.rs	88.0%	3 Missing ⚠️
crates/weaver_resolver/src/dependency.rs	93.3%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #1669   +/-   ##
=====================================
  Coverage   81.4%   81.4%           
=====================================
  Files        131     131           
  Lines      11714   11754   +40     
=====================================
+ Hits        9538    9577   +39     
- Misses      2176    2177    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR fixes attribute provenance and reference resolution when attributes are inherited through dependency refinements, ensuring provenance points to the true defining registry and preventing “inherited-through-refinement” attribute instances from being treated as definitions a bare ref can resolve against. It also aligns behavior between dependencies consumed from source and from published artifacts, as described in issue #1658.

Changes:

• Track an attribute’s defining registry (“origin”) through inheritance/refinement so resolved provenance is attributed to the correct schema URL.
• Prevent inherited-through-refinement attributes from becoming root definitions usable for bare ref resolution, avoiding incorrect resolution against a refinement’s local copy.
• Add regression tests + fixtures covering transitive provenance, “inherited is not a definition”, and v1-dependency provenance.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/weaver_resolver/src/registry.rs	Propagates origin through inheritance and passes it into attribute reference resolution.
crates/weaver_resolver/src/lib.rs	Adds regression tests for transitive provenance and “inherited attribute is not a definition” behavior.
crates/weaver_resolver/src/dependency.rs	Determines attribute origin when building refinement summaries from v1/v2 dependencies.
crates/weaver_resolver/src/attribute.rs	Introduces is_definition handling for root attributes so inherited instances don’t satisfy bare ref resolution.
crates/weaver_resolver/data/registry-test-v2-dep/v1_dep_registry/registry/registry.yaml	New fixture: v2 registry refining a metric from a v1 dependency.
crates/weaver_resolver/data/registry-test-v2-dep/v1_dep_registry/registry/manifest.yaml	New fixture manifest for v1-dependency provenance test.
crates/weaver_resolver/data/registry-test-v2-dep/v1_dep_registry/expected-schema.yaml	Expected resolved output validating correct provenance across v1 + transitive dependencies.
crates/weaver_resolver/data/registry-test-v2-dep/span_registry/expected-schema.yaml	Updates expected outputs to include provenance on catalog attributes.
crates/weaver_resolver/data/registry-test-v2-dep/metric_registry/expected-schema.yaml	Updates expected outputs to include provenance on catalog attributes.
crates/weaver_resolver/data/registry-test-v2-dep/event_registry/expected-schema.yaml	Updates expected outputs to include provenance on catalog attributes.
crates/weaver_resolver/data/registry-test-v2-dep/entity_registry/expected-schema.yaml	Updates expected outputs to include provenance on catalog attributes.
crates/weaver_resolver/data/registry-test-v2-dep/deep_registry/registry/registry.yaml	New fixture: transitive dependency provenance through deeper attribute definition.
crates/weaver_resolver/data/registry-test-v2-dep/deep_registry/registry/manifest.yaml	New fixture manifest for deep/transitive provenance test.
crates/weaver_resolver/data/registry-test-v2-dep/deep_registry/expected-schema.yaml	Expected resolved output validating provenance points at the deeper defining registry.
crates/weaver_resolver/data/inherited-ref-test/user/registry.yaml	New fixture: refinement brings inherited attr into scope; bare ref must still fail.
crates/weaver_resolver/data/inherited-ref-test/user/manifest.yaml	New fixture manifest for inherited-ref test (published dependency form).
crates/weaver_resolver/data/inherited-ref-test/refiner/registry.yaml	New fixture: refiner that refines but defines nothing.
crates/weaver_resolver/data/inherited-ref-test/refiner/manifest.yaml	New fixture manifest for refiner-from-source scenario.
crates/weaver_resolver/data/inherited-ref-test/refiner_user/registry.yaml	New fixture: consumes refiner from source and tries to ref inherited attribute (must fail).
crates/weaver_resolver/data/inherited-ref-test/refiner_user/manifest.yaml	New fixture manifest for refiner_user.
crates/weaver_resolver/data/inherited-ref-test/middle/registry.yaml	New fixture: middle uses base attribute without defining it.
crates/weaver_resolver/data/inherited-ref-test/middle/manifest.yaml	New fixture manifest for middle.
crates/weaver_resolver/data/inherited-ref-test/middle_published/resolved.yaml	New fixture: published-form resolved schema used as dependency in tests.
crates/weaver_resolver/data/inherited-ref-test/middle_published/manifest.yaml	New fixture manifest for published middle.
crates/weaver_resolver/data/inherited-ref-test/base/registry.yaml	New fixture: base defines base.attr.
crates/weaver_resolver/data/inherited-ref-test/base/manifest.yaml	New fixture manifest for base.
crates/weaver_resolved_schema/src/catalog.rs	Adds RootAttribute and a root_attribute_definition API to distinguish definitions vs inherited instances.
crates/weaver_resolved_schema/src/attribute.rs	Extends UnresolvedAttribute with origin to track defining schema URL through resolution.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.