Helm Chart addition for reg service - #239
Conversation
pdowler
left a comment
pdowler
left a comment
There was a problem hiding this comment.
I have not heard of any decision about the files in cadc-registry-server so please undo modifications of those.
| {{- $conn := $connYaml | fromYaml }} | ||
| tomcat.connector.scheme={{ $conn.scheme }} | ||
| tomcat.connector.proxyName={{ $conn.proxyName }} | ||
| tomcat.connector.proxyPort={{ $conn.proxyPort }} |
There was a problem hiding this comment.
this is missing tomcat.connector.secure, which is admittedly not useful but the system prop does need to be set to true|false somehow (until it is hardcoded in the base cadc-tomcat config)
|
|
||
| reg.properties: | | ||
| {{- with .Values.application.authority }} | ||
| org.opencadc.reg.authority = {{ . }} |
There was a problem hiding this comment.
By itself, enabling this is not enough for OAI publishing: a deployer has to also mount a directory with the OAI content... we (CADC) do not yet do it that way (for reasons). Not really ready for general use yet.
There was a problem hiding this comment.
Got it. I've removed the reg.properties file configuration entirely for OAI, and left out any documentation with regard to enabling it.
| {{ end }} | ||
| {{ end }} | ||
| {{ with .Values.application.vosi }} | ||
| cadc-vosi.properties: |
There was a problem hiding this comment.
The reg service (code) does not support state change via /availability s this config file and startupMode don't do anything. In fact, POST /availability will respond with a 400 from an UnsupportedOperationException. Probably better to omit this entirely.
There was a problem hiding this comment.
OK, good. This file is no longer used.
|
Comments addressed. |
2 participants
Changes
regPOF values file deployed in the Keel Metal cluster:
https://github.com/cadc-ccda-infra/keel-deploy/blob/main/helm/values/cadc-west.canfar.net/reg/base.yaml
https://github.com/cadc-ccda-infra/keel-deploy/blob/main/helm/values/cadc-west.canfar.net/reg/prod.yaml