fix: accept Claude native trajectories - #52
Conversation
|
Codex review: blocked before merge. Reviewed September 4, 2026, 2:59 PM ET / 18:59 UTC. ClawSweeper reviewWhat this changesThe PR classifies Claude Code native trajectories as real harness events and adds coverage for the native-harness classification. Merge readiness⛔ Blocked before merge - 4 items remain Keep open: current main still excludes Claude Code from real native trajectories despite its existing validated stream reconstruction. This member-authored PR is a narrow fix, but its exact head conflicts with main and its benchmark-eligibility policy needs explicit approval. Priority: P2 Review scores
Verification
How this fits togetherShellBench’s native evaluator reconstructs each harness’s trace and aggregates completed results into eligibility and scores. This classification determines whether Claude Code’s reconstructed trace can count in that aggregation. flowchart LR
A[Claude Code stream output] --> B[Trajectory reconstruction]
B --> C[Trajectory classification]
C --> D[Native result aggregation]
D --> E[Eligibility and scores]
Decision needed
Why: The code already reconstructs and validates Claude traces, but changing the allowlist changes which runs may enter benchmark results; that comparability policy cannot be inferred from implementation alone. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Rebase the focused classification and regression test onto current main, retain the existing Claude stream validation, and merge only after maintainers approve its use as comparable benchmark evidence. Do we have a high-confidence way to reproduce the issue? Yes, source inspection gives a high-confidence path: a completed Claude Code run can reconstruct as real, yet current main writes an unsupported manifest mode that aggregation excludes. Is this the best way to solve the issue? Yes, conditionally: adding Claude Code to the existing allowlist is the narrowest repair once maintainers approve its reconstructed stream as comparable benchmark evidence. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against c1a79f731541. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (66 earlier review cycles; latest 8 shown)
|
What does this PR do?
Marks Claude Code native trajectories as real harness events so completed Claude runs remain eligible for native aggregation.
Why?
The native runner already converts Claude Code
stream-jsonoutput intotrajectory.json, but the harness allowlist omittedclaude-code. Aggregation therefore classified otherwise valid Claude runs astrajectory_unavailable.Changes
claude-codeto the real-trajectory harness allowlistreal_harness_eventsLive proof
A native Claude Code control run completed four tasks with four result files, four valid completed results, and no infrastructure failures. Aggregation classified every trajectory as
real; the run remained ineligible only because it was intentionally marked as an exploratory four-task subset.4/40.753truerealfor all four tasks0exploratory_subsetTests
python -m pytest -qpasses locally (444 passed, 5 skipped)python -m ruff check clawbench app.py scripts testspasses locally