feat(native-eval): export tool discovery telemetry - #60
Conversation
|
Codex review: blocked before merge. Reviewed September 5, 2026, 2:55 AM ET / 06:55 UTC. ClawSweeper reviewWhat this changesAdds a separate research CSV for tool discovery operations, counter normalization, and task-level discovery status, runner identity, and trace fidelity. Merge readiness⛔ Blocked before merge - 5 items remain Keep open: current main does not implement the linked request, and the branch still permits misleading discovery totals. The previous classification and documentation findings remain unresolved. Priority: P2 Review scores
Verification
How this fits togetherShellBench’s research exporter reads benchmark run metadata and normalized agent traces. It produces CSV tables that researchers use to compare tool use, model identity, and resource consumption across harnesses. flowchart TD
A[Run metadata] --> C[Research exporter]
B[Agent traces] --> C
C --> D[Extract discovery evidence]
D --> E[Validate scopes and normalize counters]
E --> F[Discovery operations CSV]
E --> G[Task inventory and summary]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Keep discovery exports separate, preserve unknown evidence states, and normalize valid scoped telemetry independently of optional mode metadata. Do we have a high-confidence way to reproduce the issue? Yes, the PR-head source provides clear triggers: omit mode metadata with no discovery evidence, or retain scoped telemetry while omitting mode metadata. No target code or tests were executed during this read-only review. Is this the best way to solve the issue? The separate export is appropriate, but its evidence handling needs repair. Explicit mode persistence is necessary only for claims about configured state; older artifacts can remain safely unobservable while their valid scoped telemetry is normalized. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against c1a79f731541. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (75 earlier review cycles; latest 8 shown)
|
What does this PR do?
Exports native-harness tool discovery operations separately from final tool
calls and records the trace fidelity needed to interpret missing events.
Why?
Fixes #59.
The existing research audit records
tool_search_codeas one wrapper call butdrops OpenClaw's embedded catalog and search/describe/call counters. It also
cannot distinguish disabled discovery from unsupported or unobservable native
events, which makes cross-harness comparisons produce fake zeros.
Changes
discovery_events.csvwith normalized search, describe, and call countsTests
python -m pytest -q tests/test_native_eval_research_audit.pypython -m ruff check scripts/native_eval/research_audit.py tests/test_native_eval_research_audit.pyall three tasks report the expected runner SHA, session fidelity,
disableddiscovery state, and zero discovery operations