chore(deps): refresh validation and container dependencies - #78
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs real behavior proof before merge. Reviewed August 31, 2026, 3:27 AM ET / 07:27 UTC. ClawSweeper reviewWhat this changesThe PR raises the Pydantic minimum, updates container-installed Playwright and Chromium, and changes the Kubernetes MLflow default to 3.15.2 with matching script help and documentation. Merge readiness⛔ Blocked until stronger real behavior proof is added - 4 items remain Keep this PR open: it changes the MLflow image automatically used by existing Kubernetes deployments, but the supplied MLflow smoke starts with a new tmpfs database and does not prove that the PVC-backed database created by 3.14.0 remains usable after the upgrade. The prior P1 concern remains on the unchanged head. Priority: P2 Review scores
Verification
How this fits togetherThe Kubernetes deployment script provisions an MLflow tracking server for ClawBench evaluation results. Its default image is applied to the MLflow Deployment, which mounts a persistent volume containing the tracking database and artifacts. flowchart LR
A[Deployment command] --> B[MLflow image default]
B --> C[MLflow Kubernetes Deployment]
C --> D[Persistent volume]
D --> E[SQLite tracking database]
E --> F[ClawBench result logging]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Exercise a retained 3.14.0 MLflow volume through deployment to 3.15.2 and verify startup plus historical run and artifact readback, or explicitly document and enforce an intentional migration and rollback contract. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug report: this is a dependency-refresh PR. The missing validation is a concrete upgrade scenario using a retained 3.14.0 Kubernetes volume and the new default. Is this the best way to solve the issue? No; the dependency alignment is coherent, but merging a persistent-service default without retained-state upgrade evidence is not the safest complete solution. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 7e117cba3bd8. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
What does this PR do?
Refresh the remaining application/container dependency pins after the recent Python update: Pydantic 2.13.4 → 2.13.5, Playwright 1.59.1 → 1.62.1 in both Dockerfiles, and the Kubernetes MLflow server 3.14.0 → 3.15.2. Keep the MLflow manifest, deploy-script defaults, help, and documentation aligned.
Why?
Pydantic has a new patch release, the bundled Chromium was behind, and the Kubernetes MLflow server lagged the already-current Python extra. No new dependencies or lockfiles were introduced. This repository uses pip and has no dependency lockfile.
Changes
All changes are patch/minor upgrades. Other direct Python requirements, GitHub Actions, pre-commit hooks, and the HF mirror client already resolve to current stable releases. Python 3.11 keeps its compatible NumPy 2.4.6 range; Python 3.12+ uses 2.5.2.
The fixed OpenClaw image digest and native campaign harness/Node/LiteLLM versions remain reproducibility inputs. Upgrade those in a separately qualified campaign. The optional Hermes source requirement already tracks main.
Upstream notes reviewed: Pydantic 2.13.5, Playwright release notes, and MLflow 3.15.2. Playwright is used here to install Chromium; removed application APIs in its release notes are not used by these Docker commands.
Tests
Local validation uses Python 3.12.14 with the dev and MLflow extras installed.
python -m pip checkreportsNo broken requirements found.Full Ruff lint reportsAll checks passed!. The full local suite passed: 515 passed, 5 skipped, 1 warning in 268.13s. The existing five skips require the privatetasks/holdout, which is absent in this public checkout. The warning is the existing Gradio 6 theme/CSS argument deprecation.The package wheel built successfully and contains all four runtime-data entries checked by CI. After replacing the editable install with that wheel, the actual
clawbench list-tasksentry point ran from a scratch working directory. Its exact task IDs matched the packaged YAML definitions: 19 Core v1 tasks plus eight perturbed variants.A full HF image build was attempted but canceled during slow local build-context processing; no full image rebuild is claimed.
The updated Chromium was launched through Playwright against a local HTTP server serving the real public newsletter-form fixture. The smoke check loaded the form and filled its email input:
The MLflow 3.15.2 container ran locally with an ephemeral SQLite database on tmpfs. The repository's
scripts/log_to_mlflow.pylogged an explicitly synthetic result to an experiment configured with a proxied artifact URI. Client readback verified the metric, model parameter, and JSON artifact:These checks validate dependency/runtime behavior. The synthetic score is a test fixture.
Exact local commands
The temporary smoke helpers below make these commands reproducible. They are included here as proof scaffolding.
Smoke helper source
cli-proof.pybrowser-proof.cjsmlflow-roundtrip.pyCI reasoning
The orchestrator's NORUNS snapshot was stale. Default-branch build/test CI was already green at 7e117cb. The updated branch push run and PR run at 42d6294 are green: both Python 3.11 and 3.12 pass full Ruff lint, runtime contract smoke tests, the full test suite, and wheel runtime-data verification. CodeQL analyses for Python, JavaScript/TypeScript, and Actions also passed. No assertions or jobs were weakened.
The HF mirror is a deployment workflow, not test CI; its latest main run is successful. ClawSweeper dispatch is operations automation; Testbox and Crabbox hydration are manual validation infrastructure. No production deployment or credentials were changed.
Codex autoreview completed scoped-clean at its default P0 threshold, with no accepted/actionable findings. This PR is for orchestrator review and has not been merged.