fix: make grading cross-platform - #79
Closed
paulcam206 wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalizes completion golden-text line endings and makes trajectory shell classification recognize cross-platform read/search commands without treating harmless stderr redirects as mutations.
Why?
Windows CRLF output can fail against equivalent LF golden text, and common PowerShell/CMD inspection commands are misclassified. Read-only grep/find commands that discard or merge stderr are also incorrectly marked as edits.
Changes
Tests
python -m pytest -qpasses locallypython -m pytest -q tests/test_environment.py tests/test_environment_files.py tests/test_trajectory.pypython -m ruff check clawbench app.py scripts testspasses locally