Skip to content

chore(deps): bump github.com/mattn/go-runewidth from 0.0.27 to 0.0.28 - #160

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/github.com/mattn/go-runewidth-0.0.28
Closed

chore(deps): bump github.com/mattn/go-runewidth from 0.0.27 to 0.0.28#160
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/github.com/mattn/go-runewidth-0.0.28

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 23, 2026

Copy link
Copy Markdown
Contributor

Bumps github.com/mattn/go-runewidth from 0.0.27 to 0.0.28.

Commits
  • 554428c Merge pull request #105 from mattn/lazy-width-lut
  • 27d1448 Avoid regexp and map construction at package load
  • 69a63c6 Build the strict width LUT lazily to fix startup regression
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/mattn/go-runewidth](https://github.com/mattn/go-runewidth) from 0.0.27 to 0.0.28.
- [Commits](mattn/go-runewidth@v0.0.27...v0.0.28)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-runewidth
  dependency-version: 0.0.28
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Aug 23, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner August 23, 2026 20:13
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Aug 23, 2026
@clawsweeper

clawsweeper Bot commented Aug 23, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Aug 23, 2026
@clawsweeper

clawsweeper Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed August 27, 2026, 12:47 PM ET / 16:47 UTC.

ClawSweeper review

What this changes

The PR updates the direct Go module github.com/mattn/go-runewidth from v0.0.27 to v0.0.28 and refreshes its checksums.

Merge readiness

⚠️ Ready for maintainer review - 2 items remain

Keep open for ordinary maintainer review: current main still pins v0.0.27, while this direct runtime module determines terminal display widths.

Likely related people: steipete (recent dependency and renderer work, high confidence); Vincent Koc (earlier CLI rendering work, medium confidence).

Priority: P3
Reviewed head: e4bbe2ba8a0ab7912b0a6562973ad8b089705907

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) This is a focused conventional dependency update with passing supplied checks, while its direct terminal-rendering compatibility still merits confirmation.
Proof confidence 🌊 off-meta tidepool Not applicable: This Dependabot bot PR is exempt from the external-contributor real-behavior-proof gate; the supplied CI results remain supplemental evidence.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: This Dependabot bot PR is exempt from the external-contributor real-behavior-proof gate; the supplied CI results remain supplemental evidence.
Evidence reviewed 6 items Verified introduced scope: The pinned merge-base-to-head delta changes only the requested module version and the two matching go.sum entries.
Current main still needs this update: The current default-branch revision retains github.com/mattn/go-runewidth v0.0.27, so the requested v0.0.28 bump is not already implemented on main.
Direct rendering dependency: The CLI renderer directly imports go-runewidth and uses RuneWidth and StringWidth for clipping and alignment.
Findings None None.
Security None None.

How this fits together

Slacrawl’s CLI renderer formats archived Slack data for terminals. It sends text through Unicode display-width measurement before producing aligned tables and safely truncated output.

flowchart LR
A[Archived Slack data] --> B[CLI renderer]
B --> C[Unicode width measurement]
C --> D[Truncation and table padding]
D --> E[Terminal output]
Loading

Before merge

  • Resolve merge risk (P1) - Merging changes a direct dependency used to compute Unicode widths for terminal truncation and column alignment; supplied checks do not show a representative post-upgrade render.
  • Complete next step (P2) - No concrete branch defect warrants an automated repair; this needs ordinary maintainer confirmation of the direct dependency’s rendering compatibility.
Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Module update scope 2 files affected; 3 additions, 3 deletions The branch is limited to one version declaration and its matching module checksums.

Merge-risk options

Maintainer options:

  1. Confirm terminal rendering (recommended)
    Run a representative CLI render with emoji and CJK text before merging this direct display-width dependency update.

Technical review

Best possible solution:

Retain the minimal version bump after a focused CLI rendering smoke check confirms emoji and CJK text still truncate and align as expected.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a dependency maintenance PR, not a report of broken behavior.

Is this the best way to solve the issue?

Yes, conditionally: a narrowly pinned module update is the maintainable path once Slacrawl’s existing Unicode rendering behavior is checked after the upgrade.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning high; reviewed against 526888485c56.

Labels

Label justifications:

  • P3: This is a routine patch-level dependency update with limited user-facing surface.
  • merge-risk: 🚨 compatibility: The bumped direct module computes terminal text widths used by Slacrawl’s truncation and alignment paths.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This Dependabot bot PR is exempt from the external-contributor real-behavior-proof gate; the supplied CI results remain supplemental evidence.

Evidence

What I checked:

  • Verified introduced scope: The pinned merge-base-to-head delta changes only the requested module version and the two matching go.sum entries. (go.mod:8, e4bbe2ba8a0a)
  • Current main still needs this update: The current default-branch revision retains github.com/mattn/go-runewidth v0.0.27, so the requested v0.0.28 bump is not already implemented on main. (go.mod:8, 526888485c56)
  • Direct rendering dependency: The CLI renderer directly imports go-runewidth and uses RuneWidth and StringWidth for clipping and alignment. (internal/cli/render.go:12, 526888485c56)
  • Existing rendering contract coverage: Current tests cover UTF-8-safe trimming and alignment with wide characters, providing a focused compatibility surface for this update. (internal/cli/render_test.go:30, e4bbe2ba8a0a)
  • Area provenance: History shows Peter Steinberger’s recent renderer and dependency work, with Vincent Koc contributing the earlier archive-report CLI rendering surface. (internal/cli/render.go:288, b4d5fecd6fd6)
  • Supplied CI evidence: The provided PR context reports successful lint, test, CodeQL, dependency, Docker, and release-check runs for this exact head. (e4bbe2ba8a0a)

Likely related people:

  • steipete: Peter Steinberger authored the current-main dependency refresh and a recent rendering test change. (role: recent dependency and CLI rendering contributor; confidence: high; commits: 526888485c56, b4d5fecd6fd6; files: go.mod, internal/cli/render.go, internal/cli/render_test.go)
  • Vincent Koc: History attributes the archive-report CLI rendering work to Vincent Koc. (role: earlier CLI rendering contributor; confidence: medium; commits: c7f233c907e0; files: internal/cli/render.go, internal/cli/render_test.go)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Run a representative CLI render containing emoji and CJK text and retain a redacted terminal transcript if output differs.

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (11 earlier review cycles; latest 8 shown)
  • reviewed 2026-08-24T19:09:36.770Z sha e4bbe2b :: needs maintainer review before merge. :: none
  • reviewed 2026-08-24T19:28:27.306Z sha e4bbe2b :: needs maintainer review before merge. :: none
  • reviewed 2026-08-25T04:08:35.909Z sha e4bbe2b :: needs maintainer review before merge. :: none
  • reviewed 2026-08-25T17:06:01.595Z sha e4bbe2b :: needs maintainer review before merge. :: none
  • reviewed 2026-08-25T23:11:22.515Z sha e4bbe2b :: needs maintainer review before merge. :: none
  • reviewed 2026-08-26T05:49:50.695Z sha e4bbe2b :: needs maintainer review before merge. :: none
  • reviewed 2026-08-26T17:22:37.806Z sha e4bbe2b :: needs maintainer review before merge. :: none
  • reviewed 2026-08-26T22:44:56.808Z sha e4bbe2b :: needs maintainer review before merge. :: none

@clawsweeper clawsweeper Bot added the merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. label Aug 26, 2026
@steipete

Copy link
Copy Markdown
Collaborator

Superseded by #162, which landed this update in a consolidated dependency refresh (merged to main).

@steipete steipete closed this Aug 28, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/go_modules/github.com/mattn/go-runewidth-0.0.28 branch August 28, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore dependencies Pull requests that update a dependency file go Pull requests that update go code merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. other P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants