chore(deps): bump github.com/mattn/go-runewidth from 0.0.27 to 0.0.28 - #160
chore(deps): bump github.com/mattn/go-runewidth from 0.0.27 to 0.0.28#160dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github.com/mattn/go-runewidth](https://github.com/mattn/go-runewidth) from 0.0.27 to 0.0.28. - [Commits](mattn/go-runewidth@v0.0.27...v0.0.28) --- updated-dependencies: - dependency-name: github.com/mattn/go-runewidth dependency-version: 0.0.28 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 27, 2026, 12:47 PM ET / 16:47 UTC. ClawSweeper reviewWhat this changesThe PR updates the direct Go module github.com/mattn/go-runewidth from v0.0.27 to v0.0.28 and refreshes its checksums. Merge readinessKeep open for ordinary maintainer review: current main still pins v0.0.27, while this direct runtime module determines terminal display widths. Likely related people: steipete (recent dependency and renderer work, high confidence); Vincent Koc (earlier CLI rendering work, medium confidence). Priority: P3 Review scores
Verification
How this fits togetherSlacrawl’s CLI renderer formats archived Slack data for terminals. It sends text through Unicode display-width measurement before producing aligned tables and safely truncated output. flowchart LR
A[Archived Slack data] --> B[CLI renderer]
B --> C[Unicode width measurement]
C --> D[Truncation and table padding]
D --> E[Terminal output]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the minimal version bump after a focused CLI rendering smoke check confirms emoji and CJK text still truncate and align as expected. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a dependency maintenance PR, not a report of broken behavior. Is this the best way to solve the issue? Yes, conditionally: a narrowly pinned module update is the maintainable path once Slacrawl’s existing Unicode rendering behavior is checked after the upgrade. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 526888485c56. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (11 earlier review cycles; latest 8 shown)
|
|
Superseded by #162, which landed this update in a consolidated dependency refresh (merged to main). |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/mattn/go-runewidth from 0.0.27 to 0.0.28.
Commits
554428cMerge pull request #105 from mattn/lazy-width-lut27d1448Avoid regexp and map construction at package load69a63c6Build the strict width LUT lazily to fix startup regressionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)