Fix account stuck in "Connecting" state after network switch - #969
Merged
TheOneRing merged 1 commit intoJul 9, 2026
Merged
Conversation
When switching networks (e.g. WiFi to mobile hotspot), the running ConnectionValidator's HTTP request could hang on the dead socket. The guard in checkConnectivity() would then block all subsequent reconnection attempts, leaving the account permanently stuck. Two fixes: - Abort any stale ConnectionValidator when reachability or captive portal state changes, so a fresh validation can start immediately. - Add a 60-second hard timeout to ConnectionValidator to abort hung requests as a safety net.
TheOneRing
force-pushed
the
fix/network-switch-recovery
branch
from
July 9, 2026 08:56
a8ec461 to
d009495
Compare
TheOneRing
approved these changes
Jul 9, 2026
TheOneRing
left a comment
TheOneRing
left a comment
Contributor
There was a problem hiding this comment.
Interesting find, thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching networks (e.g. WiFi → mobile hotspot), a running
ConnectionValidator's HTTP request could hang on the dead socket. The guard incheckConnectivity()would then block all subsequent reconnection attempts, leaving the account permanently stuck in "Connecting".Two fixes:
ConnectionValidatorwhen reachability or captive-portal state changes, so a fresh validation can start immediately, and clear the access manager's connection cache so new requests open fresh sockets on the new interface.ConnectionValidatorto abort hung requests as a safety net.Split out of #858 so it can be reviewed independently.
Tested on openSUSE Tumbleweed x86_64.