release: 1.0.0 (first stable) - #19
Merged
Merged
Conversation
zylos-luna-coco
approved these changes
Jul 20, 2026
zylos-luna-coco
left a comment
zylos-luna-coco
left a comment
There was a problem hiding this comment.
Version-bump only: 0.1.0-alpha.3 → 1.0.0, no code change. Verified:
- main contains #18 (token-cache root fix) —
c189286is HEAD. - Dist-tag logic correct:
1.0.0has no hyphen →DIST_TAG="latest"perrelease.yml:59. The pre-stable alpha→latest convenience block (release.yml:63-77) will no-op sinceDIST_TAG != "alpha". Barenpm install @openmaxai/openmax-agent-sdkwill resolve 1.0.0 from this point forward. - Ancestry gate (
release.yml:25-31): tag must be on main, so only code that passed branch protection review can be published — supply chain sound. - Protected
releaseenvironment gates the publish behind human approval — no accidental pushes.
LGTM.
…#19 review) - src/index.js: SDK_VERSION now derived from package.json via createRequire (single source of truth) instead of a hardcoded '0.1.0-alpha.0' — was a runtime-visible version drift; now can't recur. - README: install command drops the `@alpha` tag, obsolete 'no stable release yet' warning replaced with a 1.0.0-stable note, Status bumped to 1.0.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bring the release branch up to date with main so the 1.0.0 release includes the newly-added PR-triggered CI (SAST/secret-scan/tests) and the Semgrep finding fixes (shell-injection env-indirection + rule-specific nosemgrep). No file overlap with the version bump → conflict-free.
zylos-luna-coco
approved these changes
Jul 20, 2026
zylos-luna-coco
left a comment
zylos-luna-coco
left a comment
There was a problem hiding this comment.
Re-approved after update (head 25f581f). New additions since last review:
- README: Installation section updated for 1.0.0 (removes @Alpha caveat, notes alpha dist-tag for history). Status section updated. Correct.
- SDK_VERSION: now
createRequire(import.meta.url)('../package.json').versioninstead of a hardcoded string — eliminates version drift between package.json and the exported constant.createRequireis the standard ESM pattern for reading JSON; correct.
Combined with the original version bump, this is a complete 1.0.0 release PR. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote
@openmaxai/openmax-agent-sdkfrom0.1.0-alpha.3→1.0.0(first stable).mainalready contains the token-cache root fix (fix(token): bind cached JWT to the api_key that minted it (fix wrong-identity on api_key swap) #18): cached JWT is bound to the api_key fingerprint and re-exchanged on mismatch (fixes wrong-identity on api_key swap within an org).package.json+package-lock.jsononly (no code change here).v1.0.0triggers the release workflow →npm publish --provenanceto thelatestdist-tag (1.0.0 has no hyphen), gated on the protectedreleaseenvironment (human approval).🤖 Generated with Claude Code