docs: trim badge row, advertise MOQT draft-18 - #526
Merged
Conversation
The badge row's summed intrinsic width had grown to ~921px against a ~920px README column, putting it on the wrap threshold. Drop the ci pr badge (~110px) to restore margin; ci main already covers build health. The MOQT badge advertised draft-16. kSupportedVersions negotiates draft-14/15/16/18, with ALPN moqt-18.
afrind
approved these changes
Jul 29, 2026
afrind
left a comment
Contributor
There was a problem hiding this comment.
I don't totally get what you are after here, but stamping to unblock
@afrind reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gmarzot).
-- commits line 9 at r1:
What is this saying? What is the badge even for?
Contributor
Author
Previously, afrind wrote…
|
Contributor
Author
|
there was some whacked thing where the badges were all stacked and looked like a mess... claude said the dimensions needed to be fiddled.. but also noticed draft-18 was not being advertised.. and useless pr ci status removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Two independent README fixes.
Badge row width
GitHub emits the badges as a single inline
<p>— verified against both the API render and the repo landing page payload. No<br>, and no rule inprimer-*.css/github-*.cssthat would break the line. So the row is plain inline flow that wraps on width.Summed intrinsic widths of the eight badge SVGs: 890px, plus seven inter-badge word-spaces ≈ 921px. The README column is ~920px — provable, since
docs/banner.pngis 5072px intrinsic andmax-width:100%pins it to exactly the container width. The row had drifted onto the wrap threshold on its own:releasewidened with the version tag,issuesgained a digit.Dropping
ci pr(~110px) brings it to ~810px with margin.ci mainalready covers build health;last commitis kept for the freshness signal.MOQT draft version
The badge advertised
draft-16. Perdeps/moxygen/moxygen/MoQVersions.h:with
kAlpnMoqtDraft18 = "moqt-18". Badge now readsdraft-18.Open question
This does not fully explain a report of the badges rendering one per line. Geometry says a 921px row in a 920px column wraps to two lines, not eight, and the stacking reproduced in incognito so it is not a browser extension. Landing this narrows the variable: if the row goes horizontal, it was width. If seven badges still stack, something is forcing breaks and needs a separate look.
This change is