stats: name PUBLISH counters by relay role - #528
Merged
Conversation
PUBLISH counters now follow the same convention as SUBSCRIBE: the prefix is the relay's own role and Success/Error is the request outcome. moqPublishSuccess -> pubPublishSuccess (relay sent PUBLISH) moqPublishError -> pubPublishError moqPublishOkSent -> subPublishSuccess (relay received PUBLISH) moqPublishReceived -> dropped subPublishReceived is dropped rather than renamed: it counted request arrival, which no other handshake exposes, and its value is implied by subPublishSuccess + subPublishError. onPublish() stays as a no-op override because moxygen declares it pure virtual. Renames the exported Prometheus series, so external dashboards and alerts referencing the moqx_moqPublish* names need updating. Fixes: #151 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gmarzot
approved these changes
Jul 29, 2026
gmarzot
left a comment
gmarzot
left a comment
Contributor
There was a problem hiding this comment.
@gmarzot reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on afrind).
gmarzot
approved these changes
Jul 29, 2026
gmarzot
left a comment
gmarzot
left a comment
Contributor
There was a problem hiding this comment.
what is the rationale around moqx_ ... like a catgegory? the "moqx_moq..." vs "moqx_pub..."
@gmarzot made 1 comment.
Reviewable status:
Contributor
Author
I think I removed all the moqx_moq now. moqx prefixes all our counters -- it's always been like that, maybe just so you can tell who you are talking to if you didn't know? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUBLISH counters now follow the same convention as SUBSCRIBE: the prefix is the relay's own role and Success/Error is the request outcome.
moqPublishSuccess -> pubPublishSuccess (relay sent PUBLISH)
moqPublishError -> pubPublishError
moqPublishOkSent -> subPublishSuccess (relay received PUBLISH)
moqPublishReceived -> dropped
subPublishReceived is dropped rather than renamed: it counted request arrival, which no other handshake exposes, and its value is implied by subPublishSuccess + subPublishError. onPublish() stays as a no-op override because moxygen declares it pure virtual.
Renames the exported Prometheus series, so external dashboards and alerts referencing the moqx_moqPublish* names need updating.
Fixes: #151
This change is