Skip to content

Enhance :: Test suite#9

Merged
sadrasabouri merged 13 commits into
devfrom
enhance/tests
May 19, 2026
Merged

Enhance :: Test suite#9
sadrasabouri merged 13 commits into
devfrom
enhance/tests

Conversation

@AHReccese
Copy link
Copy Markdown
Member

@AHReccese AHReccese commented May 16, 2026

Reference Issues/PRs

What does this implement/fix? Explain your changes.

In this PR, I've enhanced test suite and I've added read-only dns parts tests + adding more CLI and util functions tests

Any other comments?

AHReccese added 8 commits May 16, 2026 19:46
@AHReccese
Add unit tests for get_backend() in WindowsDNS module
adffce4
@AHReccese
Add unit tests for get_backend() function in macOS DNS module
3f2117e
@AHReccese
Add unit tests for DNS backend retrieval and validation in Linux. Imp…
0ef7394 
…lement tests for SystemdResolvedDNS and NetworkManagerDNS, including DNS retrieval and connection name checks. Enhance get_backend() tests to ensure correct backend instantiation and interface handling.
@AHReccese
import & use default ping params
8768761
@AHReccese
Add unit tests for latency commands in dnx CLI. Implement tests for '…
e092e74 
…dnx list --latency' and 'dnx current --latency' commands
@AHReccese
Add unit tests for ping_server edge cases. Implement tests for timeou…
d1f9733 
…t handling, file not found errors, and generic exceptions to ensure robust error management in ping functionality.
@AHReccese
Add pytest marker for admin privilege tests.
9bb2ef5
@AHReccese
Add comprehensive unit tests for DNS-related functions. Implement tes…
79e901c 
…ts for platform detection, command execution, and admin privilege requirements across Unix and Windows.
@AHReccese AHReccese added this to the dnx v0.1 milestone May 16, 2026
@AHReccese AHReccese self-assigned this May 16, 2026
@AHReccese AHReccese added the enhancement New feature or request label May 16, 2026
@AHReccese AHReccese changed the title Enhance/tests Enhance :: Test suite May 16, 2026
@AHReccese AHReccese marked this pull request as ready for review May 17, 2026 00:07
@AHReccese AHReccese requested a review from sadrasabouri May 17, 2026 00:07
@sadrasabouri
Copy link
Copy Markdown
Member

sadrasabouri commented May 17, 2026

When will be our private-repo gh-action quota be reloaded? Can you ping me again once we have all tests running?

@AHReccese
Copy link
Copy Markdown
Member Author

AHReccese commented May 17, 2026 •
edited
Loading

When will be our private-repo gh-action quota be reloaded? Can you ping me again once we have all tests running?

I made the repo public, we are close to 0.1 version and it’s okay. Keep reviewing 🙌🏻

@AHReccese
Remove token requirement (public repo)
511899a 
Changed Codecov action to not fail CI on error.
sadrasabouri
sadrasabouri reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts. I have a minor suggestion.

Comment thread tests/test_linux.py
@AHReccese AHReccese requested a review from sadrasabouri May 18, 2026 15:39
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 18, 2026 •
edited
Loading

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@sadrasabouri sadrasabouri merged commit 27e549b into dev May 19, 2026
43 checks passed
@sadrasabouri sadrasabouri deleted the enhance/tests branch May 19, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadrasabouri sadrasabouri sadrasabouri approved these changes

Assignees

@AHReccese AHReccese

Labels

enhancement New feature or request

Projects

None yet

Milestone

dnx v0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@AHReccese @sadrasabouri @codecov-commenter