Skip to content

fix: Preserve YAML types in pr /var directives#104

Merged
kpouget merged 1 commit into
openshift-psap:mainfrom
albertoperdomo2:fix/pr-var-yaml-types
Jul 2, 2026
Merged

fix: Preserve YAML types in pr /var directives#104
kpouget merged 1 commit into
openshift-psap:mainfrom
albertoperdomo2:fix/pr-var-yaml-types

Conversation

@albertoperdomo2

Copy link
Copy Markdown
Collaborator

No description provided.

@albertoperdomo2 albertoperdomo2 requested a review from kpouget July 1, 2026 12:51
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kpouget, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 59a778b5-84e9-469a-a0ea-5769e6a9ff7c

📥 Commits

Reviewing files that changed from the base of the PR and between 48ac14c and 14482ea.

📒 Files selected for processing (2)
  • projects/core/ci_entrypoint/github/pr_args.py
  • projects/core/tests/test_github_pr_args.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kpouget

kpouget commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

thanks @albertoperdomo2 , can you try to launch a test to validate this?
(you can use the skeleton project, will be simpler than llm-d)

@albertoperdomo2

Copy link
Copy Markdown
Collaborator Author

/test fournos skeleton collect_cluster_info
/var skeleton.collect_cluster_info: true
/var skeleton.deep_testing: false

@albertoperdomo2

Copy link
Copy Markdown
Collaborator Author

/test fournos llm_d smoke
/cluster forge-smoke-testing
/pipeline forge-full
/var platform.artifacts.capture_namespace_events: false

@psap-forge-bot

psap-forge-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

🟢 Execution of llm_d smoke 🟢

Execution Engine Configuration

forge:
  args:
  - smoke
  configOverrides:
    platform.artifacts.capture_namespace_events: false
  project: llm_d

Artifact Links

Test Logs

00 Pre-Cleanup 5 seconds

01 Prepare 2 minutes, 58 seconds

Failure Review 011 Cluster Deploy Operator Rhcl-Operator

011__cluster_deploy_operator__rhcl-operator

The rhcl-operator.v1.4.1 ClusterServiceVersion installation failed as OLM rejected the resource during initial reconciliation, causing the CSV to immediately enter a Failed state and abort the deployment task. The failure was caused by an inability to validate or schedule the operator's deployment, with the root cause attributed to an image pull or catalog resolution failure associated with the disconnected environment configuration or a CRD readiness timeout, consistent with the disconnected: "true" annotation and OLM's rejection behavior.

04 Post-Cleanup 8 seconds

🔄 05 Export-Artifacts

@psap-forge-bot

psap-forge-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown
🔴 Submission of llm_d smoke failed after 4 minutes, 53 seconds 🔴
/test fournos llm_d smoke
/var platform.artifacts.capture_namespace_events: false
/cluster forge-smoke-testing
/pipeline forge-full

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

@albertoperdomo2: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fournos e2a68ae link true /test fournos

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kpouget

kpouget commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@kpouget

kpouget commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2026
@kpouget

kpouget commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2026
@kpouget kpouget enabled auto-merge July 2, 2026 10:59
@kpouget kpouget force-pushed the fix/pr-var-yaml-types branch from e2a68ae to 14482ea Compare July 2, 2026 11:00
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@kpouget kpouget merged commit b7d06d6 into openshift-psap:main Jul 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants