Skip to content

fix: pass full image reference to run_guidellm_benchmark#105

Merged
MML-coder merged 1 commit into
openshift-psap:mainfrom
MML-coder:rhaiis-fix-guidellm-image
Jul 1, 2026
Merged

fix: pass full image reference to run_guidellm_benchmark#105
MML-coder merged 1 commit into
openshift-psap:mainfrom
MML-coder:rhaiis-fix-guidellm-image

Conversation

@MML-coder

@MML-coder MML-coder commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The shared run_guidellm_benchmark function was refactored to take a single image param (full image:tag), but rhaiis test_phase.py still split them and passed version as a separate kwarg
  • The version kwarg was silently ignored, causing the guidellm job to pull :latest instead of :v0.6.0 and crash immediately on startup (BackoffLimitExceeded within 2 seconds)
  • Fix: pass the full benchmark_image directly as image and remove the unused version kwarg

Test plan

  • Submitted FournosJob rhaiis-mlflow-full-n277x — guidellm pod now running successfully (previously crashed within 2s)
  • Verify full pipeline completes end-to-end

Summary by CodeRabbit

  • Bug Fixes
    • Updated benchmark execution to use the full configured image reference as provided, which improves consistency when running benchmarks with custom image tags or references.

The shared guidellm runner merged image+version into a single image
param, but rhaiis still split them and passed version separately.
The version kwarg was silently ignored, causing the job to pull
:latest instead of :v0.6.0 and crash immediately.
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashtarkb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 35bd4bac-9fde-4d85-a156-ea3fd33adea1

📥 Commits

Reviewing files that changed from the base of the PR and between 8f90290 and aa8680f.

📒 Files selected for processing (1)
  • projects/rhaiis/orchestration/test_phase.py

📝 Walkthrough

Walkthrough

The benchmark invocation logic in test_phase.py was simplified by removing the step that split benchmark_image into separate image and version components. The full benchmark_image string is now passed directly as the image parameter to run_guidellm_benchmark, without a separate version argument.

Changes

Benchmark Image Argument Simplification

Layer / File(s) Summary
Remove image/version splitting
projects/rhaiis/orchestration/test_phase.py
Removed the code that split benchmark_image into image and version, and updated the run_guidellm_benchmark call to pass image=benchmark_image directly, dropping the separate version argument.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: passing the full image reference to run_guidellm_benchmark.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MML-coder MML-coder merged commit 48ac14c into openshift-psap:main Jul 1, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant