fix: pass full image reference to run_guidellm_benchmark#105
Conversation
The shared guidellm runner merged image+version into a single image param, but rhaiis still split them and passed version separately. The version kwarg was silently ignored, causing the job to pull :latest instead of :v0.6.0 and crash immediately.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe benchmark invocation logic in test_phase.py was simplified by removing the step that split benchmark_image into separate image and version components. The full benchmark_image string is now passed directly as the image parameter to run_guidellm_benchmark, without a separate version argument. ChangesBenchmark Image Argument Simplification
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
run_guidellm_benchmarkfunction was refactored to take a singleimageparam (fullimage:tag), but rhaiistest_phase.pystill split them and passedversionas a separate kwargversionkwarg was silently ignored, causing the guidellm job to pull:latestinstead of:v0.6.0and crash immediately on startup (BackoffLimitExceededwithin 2 seconds)benchmark_imagedirectly asimageand remove the unusedversionkwargTest plan
rhaiis-mlflow-full-n277x— guidellm pod now running successfully (previously crashed within 2s)Summary by CodeRabbit