WIP: [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils - #320
WIP: [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils#320bmanzari wants to merge 1 commit into
Conversation
WalkthroughAdds a Tekton pipeline for OVE 4.22 validation that extracts a catalog image from ChangesOVE 4.22 Prow integration
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant TektonPipeline
participant GetCatalogImage
participant ProvideProwjob
TektonPipeline->>GetCatalogImage: Pass SNAPSHOT
GetCatalogImage-->>TektonPipeline: Return CATALOG_IMAGE
TektonPipeline->>ProvideProwjob: Pass snapshot, CATALOG_IMAGE, and PROWJOB_NAME
ProvideProwjob-->>TektonPipeline: Run OVE 4.22 Prow job
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/ove-ui-iso-prow-job-4.22.yaml:
- Line 39: Update the jq selector in the snapshot extraction command to select
the declared 4.22 component name, installer-ove-ui-4-22-art-agent-installer-iso,
instead of ove-ui-iso-4-21, while preserving the existing containerImage
extraction.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 07f28293-f3b6-417c-ab42-c4552f0c7467
📒 Files selected for processing (1)
.tekton/ove-ui-iso-prow-job-4.22.yaml
| set -e | ||
| dnf -y install jq | ||
| echo "Snapshot: ${SNAPSHOT}" | ||
| catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}") |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Update the stale 4.21 component selector.
Line 39 selects ove-ui-iso-4-21, but the 4.22 snapshot declares installer-ove-ui-4-22-art-agent-installer-iso. This writes an empty result and invokes Prow with SNAPSHOT=.
Proposed fix
- catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}")
+ catalogImage=$(jq -r '.components[] | select(.name=="installer-ove-ui-4-22-art-agent-installer-iso") | .containerImage' <<< "${SNAPSHOT}")📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}") | |
| catalogImage=$(jq -r '.components[] | select(.name=="installer-ove-ui-4-22-art-agent-installer-iso") | .containerImage' <<< "${SNAPSHOT}") |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/ove-ui-iso-prow-job-4.22.yaml at line 39, Update the jq selector in
the snapshot extraction command to select the declared 4.22 component name,
installer-ove-ui-4-22-art-agent-installer-iso, instead of ove-ui-iso-4-21, while
preserving the existing containerImage extraction.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bmanzari The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bmanzari: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary by CodeRabbit