Skip to content

WIP: [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils - #320

Open
bmanzari wants to merge 1 commit into
openshift:mainfrom
bmanzari:AGENT-1565
Open

WIP: [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils#320
bmanzari wants to merge 1 commit into
openshift:mainfrom
bmanzari:AGENT-1565

Conversation

@bmanzari

@bmanzari bmanzari commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added an automated validation pipeline for the OVE+CNV release 4.22 workflow.
    • The pipeline dynamically identifies the required catalog image from the release snapshot.
    • Added support for triggering the configured periodic Prow validation job with release-specific parameters.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Walkthrough

Adds a Tekton pipeline for OVE 4.22 validation that extracts a catalog image from SNAPSHOT and passes it to a parameterized Prow job.

Changes

OVE 4.22 Prow integration

Layer / File(s) Summary
Pipeline extraction and Prow execution
.tekton/ove-ui-iso-prow-job-4.22.yaml
Defines pipeline parameters, extracts ove-ui-iso-4-21 from the snapshot JSON, and invokes the reusable Prow job task with the extracted catalog image and job matrix.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant TektonPipeline
  participant GetCatalogImage
  participant ProvideProwjob
  TektonPipeline->>GetCatalogImage: Pass SNAPSHOT
  GetCatalogImage-->>TektonPipeline: Return CATALOG_IMAGE
  TektonPipeline->>ProvideProwjob: Pass snapshot, CATALOG_IMAGE, and PROWJOB_NAME
  ProvideProwjob-->>TektonPipeline: Run OVE 4.22 Prow job
Loading
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The only changed file is a Tekton YAML pipeline; the diff contains no Ginkgo test titles or test code, so the check is not applicable.
Test Structure And Quality ✅ Passed No Ginkgo test code was changed; the PR only adds a Tekton YAML file, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed Only a Tekton Pipeline YAML was added; no Ginkgo e2e tests or MicroShift-sensitive test code were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only adds a Tekton pipeline YAML and no new Ginkgo e2e tests, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only adds a Tekton Pipeline; it contains no affinity, nodeSelector, replica, spread, or PDB changes that would create topology-sensitive scheduling assumptions.
Ote Binary Stdout Contract ✅ Passed PR only adds a Tekton YAML pipeline; no process-level code, main/init/TestMain, or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only changed file is a Tekton Pipeline YAML; no Ginkgo e2e test blocks or network/IP logic were added.
No-Weak-Crypto ✅ Passed New Tekton YAML contains no weak crypto, custom crypto, or secret comparisons; the only hash-like text is a sha256 image digest.
Container-Privileges ✅ Passed The new Pipeline YAML has no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, runAsUser:0, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The added logs print SNAPSHOT and a derived image string; no passwords, tokens, API keys, PII, or customer data are logged in the diff.
Title check ✅ Passed The title clearly reflects the main change: adding a new OVE 4.22 Tekton file to the repository.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bmanzari bmanzari changed the title [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils WIP: [AGENT-1565] Add OVE 4.22 tekton file to agent-installer-utils Jul 22, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tekton/ove-ui-iso-prow-job-4.22.yaml:
- Line 39: Update the jq selector in the snapshot extraction command to select
the declared 4.22 component name, installer-ove-ui-4-22-art-agent-installer-iso,
instead of ove-ui-iso-4-21, while preserving the existing containerImage
extraction.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 07f28293-f3b6-417c-ab42-c4552f0c7467

📥 Commits

Reviewing files that changed from the base of the PR and between c456e33 and 7dfbfc8.

📒 Files selected for processing (1)
  • .tekton/ove-ui-iso-prow-job-4.22.yaml

set -e
dnf -y install jq
echo "Snapshot: ${SNAPSHOT}"
catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Update the stale 4.21 component selector.

Line 39 selects ove-ui-iso-4-21, but the 4.22 snapshot declares installer-ove-ui-4-22-art-agent-installer-iso. This writes an empty result and invokes Prow with SNAPSHOT=.

Proposed fix
-              catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}")
+              catalogImage=$(jq -r '.components[] | select(.name=="installer-ove-ui-4-22-art-agent-installer-iso") | .containerImage' <<< "${SNAPSHOT}")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
catalogImage=$(jq -r '.components[] | select(.name=="ove-ui-iso-4-21") | .containerImage' <<< "${SNAPSHOT}")
catalogImage=$(jq -r '.components[] | select(.name=="installer-ove-ui-4-22-art-agent-installer-iso") | .containerImage' <<< "${SNAPSHOT}")
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/ove-ui-iso-prow-job-4.22.yaml at line 39, Update the jq selector in
the snapshot extraction command to select the declared 4.22 component name,
installer-ove-ui-4-22-art-agent-installer-iso, instead of ove-ui-iso-4-21, while
preserving the existing containerImage extraction.

@openshift-ci
openshift-ci Bot requested review from bfournie and rwsu July 22, 2026 12:57
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmanzari
Once this PR has been reviewed and has the lgtm label, please assign pawanpinjarkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown

@bmanzari: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant