Skip to content

OPRUN-4590: Add OLMLifecycleAndCompatibility feature gate#2824

Open
perdasilva wants to merge 1 commit intoopenshift:masterfrom
perdasilva:lifecycle-metadata-fg
Open

OPRUN-4590: Add OLMLifecycleAndCompatibility feature gate#2824
perdasilva wants to merge 1 commit intoopenshift:masterfrom
perdasilva:lifecycle-metadata-fg

Conversation

@perdasilva
Copy link
Copy Markdown

Summary

  • Adds a new OLMLifecycleAndCompatibility feature gate for OLM lifecycle and compatibility metadata support
  • Enabled in TechPreviewNoUpgrade and DevPreviewNoUpgrade feature sets for the SelfManaged cluster profile
  • Regenerated payload feature gate manifests via make update-payload-featuregates

Enhancement: openshift/enhancements#1991

Test plan

  • make verify-payload-featuregates passes
  • make verify passes
  • Gate appears as enabled in TechPreview/DevPreview SelfManaged manifests
  • Gate appears as disabled in Default/OKD manifests

🤖 Generated with Claude Code

Add a new feature gate for OLM lifecycle and compatibility metadata
support, enabled in TechPreviewNoUpgrade and DevPreviewNoUpgrade
feature sets for the SelfManaged cluster profile.

Enhancement: openshift/enhancements#1991

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

Hello @perdasilva! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

📝 Walkthrough

Walkthrough

A new feature gate named OLMLifecycleAndCompatibility is being introduced across the codebase. The feature gate is registered in the feature gates registry with associated metadata including Jira component, contact person, and product scope details. The gate is configured to be enabled in the DevPreviewNoUpgrade and TechPreviewNoUpgrade profiles for SelfManagedHA configurations, while being disabled across Default, OKD, and Hypershift profiles. Supporting documentation in the features table is also updated to reflect the new gate entry.

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description check ✅ Passed The description directly relates to the changeset by explaining the feature gate addition, which profiles/feature sets it affects, and references an associated enhancement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Ginkgo tests use stable deterministic names from static sources. PR changes only modify feature gate definitions and manifests, not test files or CRD files.
Test Structure And Quality ✅ Passed This custom check is not applicable to this pull request. The PR only modifies non-test files (documentation, feature gate implementation, and configuration files), containing no Ginkgo test code to evaluate against quality standards.
Microshift Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests; it only adds feature gate configuration and documentation.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request adds a new OLMLifecycleAndCompatibility feature gate to the openshift/api repository, but does not add any Ginkgo e2e tests. The changes consist entirely of feature gate configuration files and documentation.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only adds feature gate metadata, documentation, and configuration without introducing any deployment manifests or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed This PR adds feature gate definitions to an API repository with no executable binaries or test runners that could write to stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no Ginkgo e2e tests; changes are limited to feature gate definitions in configuration files.
Title check ✅ Passed The title accurately and specifically describes the main change: adding a new OLMLifecycleAndCompatibility feature gate, with the Jira ticket reference providing clear context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva perdasilva changed the title Add OLMLifecycleAndCompatibility feature gate OPRUN-4590: Add OLMLifecycleAndCompatibility feature gate Apr 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 29, 2026

@perdasilva: This pull request references OPRUN-4590 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds a new OLMLifecycleAndCompatibility feature gate for OLM lifecycle and compatibility metadata support
  • Enabled in TechPreviewNoUpgrade and DevPreviewNoUpgrade feature sets for the SelfManaged cluster profile
  • Regenerated payload feature gate manifests via make update-payload-featuregates

Enhancement: openshift/enhancements#1991

Test plan

  • make verify-payload-featuregates passes
  • make verify passes
  • Gate appears as enabled in TechPreview/DevPreview SelfManaged manifests
  • Gate appears as disabled in Default/OKD manifests

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants