MON-4561: API: Add softirqs node-exporter collector to ClusterMonitoring CRD

[danielmellado]

Port the softirqs collector configuration from the CMO ConfigMap
(cluster-monitoring-operator#2887) to the ClusterMonitoring CRD API.

The softirqs collector exposes detailed softirq statistics from
/proc/softirqs and is disabled by default. Uses the same simple
collectionPolicy pattern as other basic collectors (cpuFreq, buddyInfo, etc).

Signed-off-by: Daniel Mellado dmellado@fedoraproject.org

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@danielmellado: This pull request references MON-4561 which is a valid jira issue.

Details

In response to this:

Port the softirqs collector configuration from the CMO ConfigMap
(cluster-monitoring-operator#2887) to the ClusterMonitoring CRD API.

The softirqs collector exposes detailed softirq statistics from
/proc/softirqs and is disabled by default. Uses the same simple
collectionPolicy pattern as other basic collectors (cpuFreq, buddyInfo, etc).

Signed-off-by: Daniel Mellado dmellado@fedoraproject.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @danielmellado! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7a76093d-7775-4fc5-aefa-07f98aa697ea

📥 Commits

Reviewing files that changed from the base of the PR and between 780c45e and 3dd2dc4.

⛔ Files ignored due to path filters (5)

• config/v1alpha1/zz_generated.crd-manifests/0000_10_config-operator_01_clustermonitorings.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1alpha1/zz_generated.deepcopy.go is excluded by !**/zz_generated*
• config/v1alpha1/zz_generated.featuregated-crd-manifests/clustermonitorings.config.openshift.io/ClusterMonitoringConfig.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1alpha1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*
• openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**, !**/zz_generated*

📒 Files selected for processing (3)

• config/v1alpha1/tests/clustermonitorings.config.openshift.io/ClusterMonitoringConfig.yaml
• config/v1alpha1/types_cluster_monitoring.go
• payload-manifests/crds/0000_10_config-operator_01_clustermonitorings.crd.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• config/v1alpha1/tests/clustermonitorings.config.openshift.io/ClusterMonitoringConfig.yaml

---

📝 Walkthrough

Walkthrough

This pull request adds a softirqs collector to spec.nodeExporterConfig.collectors with a required collectionPolicy enum (Collect, DoNotCollect). It introduces NodeExporterCollectorSoftirqsConfig and a Softirqs field on NodeExporterCollectorConfig in Go types, updates the CRD schema to validate the field, and extends tests to accept valid policies and reject missing or invalid values.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	❓ Inconclusive	PR contains YAML configuration and type definitions, not Ginkgo test code. No *_test.go files with Ginkgo Describe/It blocks are modified.	Clarify if YAML test fixtures are validated by Ginkgo tests elsewhere, or if check should apply to different files.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding softirqs node-exporter collector support to the ClusterMonitoring CRD API.
Description check	✅ Passed	The description clearly explains the purpose of the change, referencing the porting of softirqs collector configuration from CMO ConfigMap to CRD API with relevant context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test files are modified in this PR; changes are limited to Go type definitions and YAML-based CRD schema validation tests.
Microshift Test Compatibility	✅ Passed	PR contains only YAML CRD configuration and Go type definitions. No Ginkgo e2e tests are being added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request does not add any Ginkgo e2e tests. The changes consist of API type definitions, CRD schema updates, and test configuration YAML files. Since the custom check only applies when new Ginkgo e2e tests are added, this check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request introduces only configuration schema definitions for softirqs collector without any deployment manifests, scheduling constraints, or topology-incompatible directives.
Ote Binary Stdout Contract	✅ Passed	PR introduces only type definitions and YAML test data files with no OTE test binaries, process-level code, or test frameworks that could output to stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR contains no Ginkgo e2e tests; only API type definitions, CRD schema updates, and declarative YAML validation test cases.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@danielmellado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	3dd2dc4	link	true	/test verify-hypershift-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[danielmellado]

Hypershift CI failure is unrelated to this PR

[danielmellado]

cc @everettraven Thanks in advance!