OCPBUGS-99492: NetworkPolicies should use numeric ports instead of named ports

[dobsonj]

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Summary by CodeRabbit

• Bug Fixes
  • Updated DNS egress network rules to explicitly allow TCP and UDP traffic on port 5353.
  • Improved DNS resolution compatibility by switching from named/non-numeric DNS port entries to the standard numeric 5353 port.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4dc07af8-e4ce-4b34-830e-82f94f5e2024

📥 Commits

Reviewing files that changed from the base of the PR and between a530735 and 7953709.

📒 Files selected for processing (2)

• manifests/09_network-policy-allow-to-dns.yaml
• manifests/09_network-policy-cso-allow-to-dns.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• manifests/09_network-policy-cso-allow-to-dns.yaml

---

Walkthrough

Both DNS egress NetworkPolicies now explicitly allow TCP and UDP traffic on numeric port 5353 instead of named DNS port values.

Changes

DNS egress policy updates

Layer / File(s)	Summary
Use numeric DNS port 5353 manifests/09_network-policy-allow-to-dns.yaml, manifests/09_network-policy-cso-allow-to-dns.yaml	Both manifests specify port 5353 for TCP and UDP DNS egress rules.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: replacing named DNS ports with numeric ports in NetworkPolicies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes two YAML manifests; no Ginkgo test files or titles were added or modified.
Test Structure And Quality	✅ Passed	PR only changes two YAML manifests; no Ginkgo tests or cluster-interaction code were added or modified, so the test-structure checklist is not applicable.
Microshift Test Compatibility	✅ Passed	Only two NetworkPolicy manifests changed; no new Ginkgo tests or unsupported MicroShift APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes NetworkPolicy manifests; no new Ginkgo tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only two NetworkPolicy manifests changed; they adjust DNS ports and add no scheduling, affinity, replica, or topology constraints.
Ote Binary Stdout Contract	✅ Passed	Only two manifest files changed; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only two NetworkPolicy manifests changed; no Ginkgo/e2e tests or connectivity assumptions were added.
No-Weak-Crypto	✅ Passed	The PR only changes two NetworkPolicy YAML manifests; no crypto code or secret comparisons were added, and touched files contain no weak-crypto indicators.
Container-Privileges	✅ Passed	Changed manifests are NetworkPolicies only; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs	✅ Passed	Only NetworkPolicy manifest ports changed; no logging code or sensitive fields/data appears in the touched files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dobsonj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dobsonj]

/jira refresh

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dobsonj]

/retest

[dobsonj]

/retest

[jsafrane]

/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-gcp-csi
/test e2e-vsphere-csi

[dobsonj]

/retest

[openshift-ci]

New changes are detected. LGTM label has been removed.

[dobsonj]

/pipeline required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-gcp-csi
/test e2e-vsphere-csi

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/cc @openshift/storage

Summary by CodeRabbit

• Bug Fixes
• Updated DNS egress network rules to explicitly allow TCP and UDP traffic on port 5353.
• Improved DNS resolution compatibility by switching from named/non-numeric DNS port entries to the standard numeric 5353 port.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dobsonj]

Apparently coredns uses port 5353:
https://github.com/openshift/cluster-dns-operator/blob/4b8ae49940eefc50fa48da5179e735dd6ccd42d9/pkg/manifests/assets/dns/daemonset.yaml#L28-L33
https://github.com/openshift/cluster-dns-operator/blob/4b8ae49940eefc50fa48da5179e735dd6ccd42d9/pkg/manifests/assets/dns/networkpolicy-allow.yaml#L13-L17

[dobsonj]

The e2e-*-csi jobs passed after changing the port number from 53 to 5353
/verified by CI

[openshift-ci-robot]

@dobsonj: This PR has been marked as verified by CI.

Details

In response to this:

The e2e-*-csi jobs passed after changing the port number from 53 to 5353
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-aws-e2e-external	7953709	link	true	/test hypershift-aws-e2e-external

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dobsonj]

/retest