Skip to content

CONSOLE-5118: Improve AI assessment prompts - #16880

Open
fao89 wants to merge 1 commit into
openshift:mainfrom
fao89:Review-CONSOLE-5118
Open

CONSOLE-5118: Improve AI assessment prompts#16880
fao89 wants to merge 1 commit into
openshift:mainfrom
fao89:Review-CONSOLE-5118

Conversation

@fao89

@fao89 fao89 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Standardize TL;DR sections across all prompt templates by moving Data Completeness near the top, simplifying its format, and enforcing terminal fields (Recommendation/Next Steps). Update the AI Assessment card icon and split the irreversibility warning into a title and body for better readability.

Analysis / Root cause:

Solution description:

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Summary by CodeRabbit

  • Improvements
    • Clarified cluster update warnings by separating the irreversible-update title from supporting readiness guidance.
    • Updated the AI Assessment alert icon for clearer visual context.
    • Standardized AI-generated update summaries with simpler data-completeness confidence levels.
    • Enforced consistent summary formatting, including placing recommendations or next steps at the end.

…y notice

Standardize TL;DR sections across all prompt templates by moving Data
Completeness near the top, simplifying its format, and enforcing terminal
fields (Recommendation/Next Steps). Update the AI Assessment card icon
and split the irreversibility warning into a title and body for better
readability.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@fao89: This pull request references CONSOLE-5118 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Standardize TL;DR sections across all prompt templates by moving Data Completeness near the top, simplifying its format, and enforcing terminal fields (Recommendation/Next Steps). Update the AI Assessment card icon and split the irreversibility warning into a title and body for better readability.

Analysis / Root cause:

Solution description:

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d4fcfb44-e897-460f-add1-65af089631c2

📥 Commits

Reviewing files that changed from the base of the PR and between 53de1c9 and cd6e6cd.

📒 Files selected for processing (8)
  • frontend/packages/console-shared/src/components/cluster-updates/prompts/precheck-no-updates.ts
  • frontend/packages/console-shared/src/components/cluster-updates/prompts/precheck-specific.ts
  • frontend/packages/console-shared/src/components/cluster-updates/prompts/precheck.ts
  • frontend/packages/console-shared/src/components/cluster-updates/prompts/progress.ts
  • frontend/packages/console-shared/src/components/cluster-updates/prompts/troubleshoot.ts
  • frontend/public/components/cluster-settings/cluster-settings.tsx
  • frontend/public/components/modals/cluster-update-modal.tsx
  • frontend/public/locales/en/public.json

Walkthrough

Changes

Cluster update prompt contracts

Layer / File(s) Summary
Standardized data completeness confidence
frontend/packages/console-shared/src/components/cluster-updates/prompts/*
TL;DR templates now express Data Completeness using High, Moderate, or Limited confidence values.
Required terminal TL;DR fields
frontend/packages/console-shared/src/components/cluster-updates/prompts/precheck*.ts, frontend/packages/console-shared/src/components/cluster-updates/prompts/troubleshoot.ts
Pre-check prompts require Recommendation as the final TL;DR field, while troubleshooting requires Next Steps as the final field.

Irreversible update alerts

Layer / File(s) Summary
Alert presentation and localization
frontend/public/components/cluster-settings/cluster-settings.tsx, frontend/public/components/modals/cluster-update-modal.tsx, frontend/public/locales/en/public.json
The AI assessment icon changes, irreversible-update messages are split between alert titles and bodies, and corresponding English translations are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: component/shared, component/dev-console, kind/i18n

Suggested reviewers: logonoff

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description does not fill the required template sections; Analysis, Solution, Tests, Screenshots, and Reviewers are all left empty. Fill in each required section with root cause, solution details, test setup/cases, screenshots or a note, browser conformance, and reviewers/assignees.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change: improving AI assessment prompts under CONSOLE-5118.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified in the touched files; the PR only changes prompts, UI copy, and locale strings.
Test Structure And Quality ✅ Passed No Ginkgo tests were added or modified; this PR changes prompt/UI text only, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; changed files are prompt/UI/localization only, with no MicroShift-sensitive APIs or skip logic needed.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff only changes prompt text, React UI, and locale strings; it adds no Ginkgo e2e tests or SNO-sensitive assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed Changed files are prompt templates and UI text only; no manifests/controllers or topology-aware scheduling logic were added.
Ote Binary Stdout Contract ✅ Passed Changed files are prompt/UI text only; no console.log/fmt.Print/klog or process-level bootstrap code appears in them.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the PR only changes prompt/UI text, and the modified files contain no test bodies or network calls.
No-Weak-Crypto ✅ Passed Touched files are prompt/UI/localization text only; exact scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-timing compares.
Container-Privileges ✅ Passed PR only changes TS/TSX/JSON files; diff search found no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed No console/logger calls or sensitive-data logging patterns found in the touched files; changes are prompt text and UI copy only.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Leo6Leo and spadgett July 29, 2026 16:28
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fao89
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@fao89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/backend cd6e6cd link true /test backend

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants