Skip to content

OCPBUGS-99498: UPSTREAM: <carry>: Dependencies bump and Go bump to 1.26.5 - #197

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:masterfrom
grzpiotrowski:bump-go-1.26.5
Jul 31, 2026
Merged

OCPBUGS-99498: UPSTREAM: <carry>: Dependencies bump and Go bump to 1.26.5#197
openshift-merge-bot[bot] merged 3 commits into
openshift:masterfrom
grzpiotrowski:bump-go-1.26.5

Conversation

@grzpiotrowski

@grzpiotrowski grzpiotrowski commented Jul 29, 2026

Copy link
Copy Markdown

Bump Go to 1.26.5

source/source.go: Use %d instead of %q for int64 TTL value in log.Warnf call. The %q verb expects a string but ttlValue is int64, causing a build failure with Go 1.26's stricter format checking.

renovate.json: Update renovate.json to limit gotoolset bumps to new minor version: 1.26.

.ci-operator.yaml: update CI image to rhel-9-release-golang-1.26-openshift-4.23

Bump golang.org/x/crypto@v0.53.0 and golang.org/x/net@v0.56.0

Additionally as a prerequisite to the next release bump version label to 1.3.8 in Containerfile.externaldns.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-99498, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump Go to 1.26.5

source/source.go: Use %d instead of %q for int64 TTL value in log.Warnf call. The %q verb expects a string but ttlValue is int64, causing a build failure with Go 1.26's stricter format checking.

renovate.json: Update renovate.json to limit gotoolset bumps to new minor version: 1.26.

Bump golang.org/x/crypto@v0.53.0 and golang.org/x/net@v0.57.0

Additionally as a prerequisite to the next release bump version label to 1.3.8 in Containerfile.externaldns.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from Thealisyed and alebedev87 July 29, 2026 14:11
@grzpiotrowski

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-99498, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from melvinjoseph86 July 29, 2026 14:12
Bumps go version to 1.26.5 to get the latest CVE fixes.

* source/source.go: Use %d instead of %q for int64 TTL value
  in log.Warnf call. The %q verb expects a string but ttlValue
  is int64, causing a build failure with Go 1.26's stricter
  format checking.
* renovate.json: Update renovate.json to limit gotoolset
  bumps to new minor version: 1.26.
* update CI image to rhel-9-release-golang-1.26-openshift-4.23
@openshift-ci-robot

Copy link
Copy Markdown

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-99498, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

Bump Go to 1.26.5

source/source.go: Use %d instead of %q for int64 TTL value in log.Warnf call. The %q verb expects a string but ttlValue is int64, causing a build failure with Go 1.26's stricter format checking.

renovate.json: Update renovate.json to limit gotoolset bumps to new minor version: 1.26.

.ci-operator.yaml: update CI image to rhel-9-release-golang-1.26-openshift-4.23

Bump golang.org/x/crypto@v0.53.0 and golang.org/x/net@v0.57.0

Additionally as a prerequisite to the next release bump version label to 1.3.8 in Containerfile.externaldns.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278

gcs278 commented Jul 29, 2026

Copy link
Copy Markdown

/assign @davidesalerno

Comment thread go.sum
@alebedev87

Copy link
Copy Markdown

@grzpiotrowski: I see that all commits have <carry> tag on them. Can you please check in which PR crypto and net modules were bumped and use those in the commit message(s) (rebase.md for details)?

… golang.org/x/net@v0.56.0

```
go get golang.org/x/net@v0.56.0
go get golang.org/x/crypto@v0.53.0
go mod tidy
go mod vendor
```
@grzpiotrowski

grzpiotrowski commented Jul 31, 2026

Copy link
Copy Markdown
Author

@grzpiotrowski: I see that all commits have <carry> tag on them. Can you please check in which PR crypto and net modules were bumped and use those in the commit message(s) (rebase.md for details)?

@alebedev87 Thanks. Done for the vendor bump commit.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@grzpiotrowski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@davidesalerno

Copy link
Copy Markdown

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidesalerno

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 268750e into openshift:master Jul 31, 2026
4 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@grzpiotrowski: Jira Issue OCPBUGS-99498: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-99498 has been moved to the MODIFIED state.

Details

In response to this:

Bump Go to 1.26.5

source/source.go: Use %d instead of %q for int64 TTL value in log.Warnf call. The %q verb expects a string but ttlValue is int64, causing a build failure with Go 1.26's stricter format checking.

renovate.json: Update renovate.json to limit gotoolset bumps to new minor version: 1.26.

.ci-operator.yaml: update CI image to rhel-9-release-golang-1.26-openshift-4.23

Bump golang.org/x/crypto@v0.53.0 and golang.org/x/net@v0.56.0

Additionally as a prerequisite to the next release bump version label to 1.3.8 in Containerfile.externaldns.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants