Skip to content

ACM-38238: Assisted-installer repos: Set Up Set up Renovate configuration to automatically create Hive API Synchronization PRs - #849

Open
shay23bra wants to merge 1 commit into
openshift:mainfrom
shay23bra:ACM-38238-Assisted-installer-repos-Set-Up-Set-up-Renovate-configuration-to-automatically-create-Hive-API-Synchronization-PRs-main
Open

ACM-38238: Assisted-installer repos: Set Up Set up Renovate configuration to automatically create Hive API Synchronization PRs#849
shay23bra wants to merge 1 commit into
openshift:mainfrom
shay23bra:ACM-38238-Assisted-installer-repos-Set-Up-Set-up-Renovate-configuration-to-automatically-create-Hive-API-Synchronization-PRs-main

Conversation

@shay23bra

@shay23bra shay23bra commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Set up Renovate configuration to automatically create Hive API Synchronization PRs.

Adds gomod to enabledManagers with postUpdateOptions (gomodUpdateImportPaths, gomodTidy), disables all gomod updates via packageRules, and enables only github.com/openshift/hive/apis.

Re-applies changes that were reverted by ACM-33186. Renovate issue is now resolved.

Summary by CodeRabbit

  • Chores
    • Updated automated dependency management for Go modules.
    • Disabled indirect Go module updates by default.
    • Enabled targeted synchronization for Hive API dependencies.
    • Added automatic import-path updates and module cleanup after dependency updates.

…tion to automatically create Hive API Synchronization PRs
@openshift-ci-robot

Copy link
Copy Markdown

@shay23bra: This pull request references ACM-38238 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Set up Renovate configuration to automatically create Hive API Synchronization PRs.

Adds gomod to enabledManagers with postUpdateOptions (gomodUpdateImportPaths, gomodTidy), disables all gomod updates via packageRules, and enables only github.com/openshift/hive/apis.

Re-applies changes that were reverted by ACM-33186. Renovate issue is now resolved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2026
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 567b1d34-b648-4f62-a153-2176cac9e5a2

📥 Commits

Reviewing files that changed from the base of the PR and between 6621941 and f92c481.

📒 Files selected for processing (1)
  • renovate.json

Walkthrough

Renovate configuration now enables Go module post-update actions, disables indirect and default Go module updates, and explicitly enables grouped updates for the Hive API dependency.

Changes

Renovate Go module rules

Layer / File(s) Summary
Go module update policy
renovate.json
Adds gomod post-update options, disables indirect and default Go module updates, and enables labeled “Hive API Synchronization” updates for github.com/openshift/hive/apis.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clearly related to the PR’s main change: configuring Renovate to create Hive API synchronization PRs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only renovate.json changed; no test files or Ginkgo titles were added or modified.
Test Structure And Quality ✅ Passed Only renovate.json changed; no Ginkgo test code was added or modified, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed Only renovate.json changed; no Ginkgo tests or runtime code were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only renovate.json changed; no Ginkgo e2e tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only renovate.json changed; no deployment manifests, operator code, or scheduling/topology logic was modified.
Ote Binary Stdout Contract ✅ Passed Only renovate.json changed; no executable or suite setup code was touched, so no process-level stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only renovate.json changed; no Ginkgo/e2e tests were added, so IPv4/disconnected compatibility concerns don't apply.
No-Weak-Crypto ✅ Passed Only renovate.json changed; no weak-crypto primitives, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed Only renovate.json changed, and it adds no privileged/container security settings like privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation:true.
No-Sensitive-Data-In-Logs ✅ Passed Only renovate.json changed; it adds Renovate rules and contains no log statements or sensitive data patterns.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from leo8a and omertuc July 26, 2026 11:52
@omer-vishlitzky

Copy link
Copy Markdown
Contributor

/retest

@omer-vishlitzky

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omer-vishlitzky, shay23bra
Once this PR has been reviewed and has the lgtm label, please assign romfreiman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

@shay23bra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibio-v4v6 f92c481 link true /test e2e-ibio-v4v6
ci/prow/ibio-reinstall-v4v6 f92c481 link false /test ibio-reinstall-v4v6
ci/prow/ibio-reinstall-v6v4 f92c481 link false /test ibio-reinstall-v6v4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants