DNM: WIP: prune master IAM role to ec2:Describe* only - #10727
Conversation
Now that AWS Cloud Controller Manager uses CCO-managed credentials via its own CredentialsRequest (openshift/cluster-cloud-controller-manager-operator), the ELB and security group permissions it previously required no longer need to live on the master node IAM instance role. The EBS CSI driver has had its own CredentialsRequest for some time, so its volume-related permissions (AttachVolume, CreateVolume, kms:DescribeKey, etc.) are also removed. After this change the master role retains only ec2:Describe*, which the kubelet needs to discover instance metadata (zone, instance type) for node self-registration. The UPI CloudFormation template (03_cluster_security.yaml) is updated to match. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/hold |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mfbonfigli: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#495
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/601f4540-8b2c-11f1-9730-6cf5c066fa5a-0 |
|
@mfbonfigli: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#495
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71101fa0-8b2c-11f1-9169-e7bbc2e6a60b-0 |
|
@mfbonfigli: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#495
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1a0849d0-8b63-11f1-9ec9-69f3ae078cb2-0 |
DO NOT MERGE
This PR is part of an effort to investigate feasbility of moving AWS CCM to CCO managed credentials. This PR is the companion of openshift/cluster-cloud-controller-manager-operator#495 and removes from master nodes IAM roles the permissions needed by CCM and provisioned via that PR through CCO.