Skip to content

DNM: WIP: prune master IAM role to ec2:Describe* only - #10727

Draft
mfbonfigli wants to merge 1 commit into
openshift:mainfrom
mfbonfigli:SPLAT-2862/use-cco-for-ccm-aws-creds
Draft

DNM: WIP: prune master IAM role to ec2:Describe* only#10727
mfbonfigli wants to merge 1 commit into
openshift:mainfrom
mfbonfigli:SPLAT-2862/use-cco-for-ccm-aws-creds

Conversation

@mfbonfigli

Copy link
Copy Markdown
Contributor

DO NOT MERGE

This PR is part of an effort to investigate feasbility of moving AWS CCM to CCO managed credentials. This PR is the companion of openshift/cluster-cloud-controller-manager-operator#495 and removes from master nodes IAM roles the permissions needed by CCM and provisioned via that PR through CCO.

Now that AWS Cloud Controller Manager uses CCO-managed credentials via
its own CredentialsRequest (openshift/cluster-cloud-controller-manager-operator),
the ELB and security group permissions it previously required no longer
need to live on the master node IAM instance role.

The EBS CSI driver has had its own CredentialsRequest for some time, so
its volume-related permissions (AttachVolume, CreateVolume, kms:DescribeKey,
etc.) are also removed.

After this change the master role retains only ec2:Describe*, which the
kubelet needs to discover instance metadata (zone, instance type) for
node self-registration.

The UPI CloudFormation template (03_cluster_security.yaml) is updated to
match.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 50a65652-7b66-4914-8dd1-aac11b0abf71

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mfbonfigli

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2026
@mfbonfigli
mfbonfigli marked this pull request as draft July 29, 2026 08:50
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@mfbonfigli: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#495
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/601f4540-8b2c-11f1-9730-6cf5c066fa5a-0

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@mfbonfigli: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#495
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71101fa0-8b2c-11f1-9169-e7bbc2e6a60b-0

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@mfbonfigli: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#495
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1a0849d0-8b63-11f1-9ec9-69f3ae078cb2-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant