Skip to content

NO-JIRA: bump controller-runtime-common to latest main#1493

Open
damdo wants to merge 2 commits intoopenshift:mainfrom
damdo:bump-controller-runtime-common
Open

NO-JIRA: bump controller-runtime-common to latest main#1493
damdo wants to merge 2 commits intoopenshift:mainfrom
damdo:bump-controller-runtime-common

Conversation

@damdo
Copy link
Copy Markdown
Member

@damdo damdo commented Apr 28, 2026

Bumps github.com/openshift/controller-runtime-common to latest main (64ee174)

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to the latest versions for improved stability and compatibility.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@damdo: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Bumps github.com/openshift/controller-runtime-common to latest main (64ee174)

Test plan

  • CI passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7b64a977-88cf-4a20-bf6f-5a5cf89bb72b

📥 Commits

Reviewing files that changed from the base of the PR and between 948a29e and 5d93d6f.

⛔ Files ignored due to path filters (3)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift/controller-runtime-common/pkg/tls/controller.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Walkthrough

A dependency version in go.mod is updated, replacing the pinned version of github.com/openshift/controller-runtime-common with a newer commit-based pseudo-version reference.

Changes

Cohort / File(s) Summary
Dependency Update
go.mod
Updated github.com/openshift/controller-runtime-common dependency to a newer commit-based pseudo-version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning New Ginkgo e2e tests in test/e2e/nutanix/multi-subnet.go assume multi-node clusters but lack SNO compatibility protections. Add [Skipped:SingleReplicaTopology] labels to test names or guard tests with exutil.IsSingleNode() checks to skip on SNO.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: bumping a dependency (controller-runtime-common) to the latest version, which directly matches the changeset that updates go.mod.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies go.mod and go.sum files to update github.com/openshift/controller-runtime-common dependency; no test files are created, modified, or deleted.
Test Structure And Quality ✅ Passed This PR is a dependency version bump with no test code modifications. The Ginkgo test files are initial additions, not changes, making the custom check inapplicable to this PR's scope.
Microshift Test Compatibility ✅ Passed This PR only updates Go module dependencies (go.mod and go.sum) by bumping controller-runtime-common package. No new Ginkgo e2e test files or test definitions are being added, so the check for new tests is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates go.mod dependency version; no scheduling constraints, manifests, or controller code modifications detected.
Ote Binary Stdout Contract ✅ Passed Pull request exclusively bumps github.com/openshift/controller-runtime-common dependency in go.mod and go.sum with no direct stdout writes in entry point binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates go.mod and go.sum files for dependency version bump. No new Ginkgo e2e tests are added or modified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from nrb and racheljpg April 28, 2026 18:40
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nrb
Copy link
Copy Markdown
Contributor

nrb commented Apr 28, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 5d93d6f link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi 5d93d6f link true /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants