NO-ISSUE: Bump github.com/InVisionApp/go-health to v2.1.4 - #6281
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@skitt: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR updates the apiserver-watcher health-check imports and Go module requirement to go-health v2.1.4, and removes an indirect go-sqlmock dependency. Changesgo-health v2 migration
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skitt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold Holding to allow the Kube rebase to land in #6321. Please ensure this will not cause merge conflicts for the Kube rebase before unholding this PR. |
This is now a Go module. Signed-off-by: Stephen Kitt <skitt@redhat.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
8-8: 🔒 Security & Privacy | 🔵 Trivial | 🏗️ Heavy liftTrack a replacement for the archived dependency.
v2.1.4is the latest release, but the upstream repository was archived on December 23, 2024. Treat this as a temporary exception and link a migration issue with an owner before relying on it for future security fixes. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 8, Add a temporary exception comment next to the github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is archived, and include a link to a migration issue with an assigned owner. Track and reference the replacement plan while retaining version v2.1.4 until migration is completed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@go.mod`:
- Line 8: Add a temporary exception comment next to the
github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is
archived, and include a link to a migration issue with an assigned owner. Track
and reference the replacement plan while retaining version v2.1.4 until
migration is completed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5039cc67-9981-4a9d-9906-9bf11f2ff6c1
⛔ Files ignored due to path filters (16)
go.sumis excluded by!**/*.sumvendor/github.com/InVisionApp/go-health/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/in-repo.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/CODEOWNERSis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/reachable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/checkers/sql.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/health.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/in-repo.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/InVisionApp/go-health/v2/safe.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (2)
cmd/apiserver-watcher/run.gogo.mod
|
@skitt: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
I noticed that github.com/InVisionApp/go-health is outdated and that the latest versions are Go modules. (The project has since been archivde though.)
- How to verify it
- Description for the changelog
Bump github.com/InVisionApp/go-health to v2.1.4
Summary by CodeRabbit