Skip to content

NO-ISSUE: Bump github.com/InVisionApp/go-health to v2.1.4 - #6281

Open
skitt wants to merge 1 commit into
openshift:mainfrom
skitt:go-health-v2
Open

NO-ISSUE: Bump github.com/InVisionApp/go-health to v2.1.4#6281
skitt wants to merge 1 commit into
openshift:mainfrom
skitt:go-health-v2

Conversation

@skitt

@skitt skitt commented Jul 7, 2026

Copy link
Copy Markdown
Member

- What I did

I noticed that github.com/InVisionApp/go-health is outdated and that the latest versions are Go modules. (The project has since been archivde though.)

- How to verify it

- Description for the changelog

Bump github.com/InVisionApp/go-health to v2.1.4

Summary by CodeRabbit

  • Bug Fixes
    • Updated health-check integration to the newer, compatible version of the health library.
    • Improved the accuracy and reliability of health status reporting, keeping overall user-facing behavior the same.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@skitt: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did

I noticed that github.com/InVisionApp/go-health is outdated and that the latest versions are Go modules. (The project has since been archivde though.)

- How to verify it

- Description for the changelog

Bump github.com/InVisionApp/go-health to v2.1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Walkthrough

This PR updates the apiserver-watcher health-check imports and Go module requirement to go-health v2.1.4, and removes an indirect go-sqlmock dependency.

Changes

go-health v2 migration

Layer / File(s) Summary
Update health imports and module requirements
cmd/apiserver-watcher/run.go, go.mod
Health imports use the /v2 module, the dependency is updated to v2.1.4, and the indirect go-sqlmock.v1 requirement is removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: harshwardhanpatil07, djoshy

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: bumping github.com/InVisionApp/go-health to v2.1.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only dependency/import updates were changed; no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed PR only updates go-health imports/deps; no *_test.go or Ginkgo test code changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the diff only updates go-health imports/dependencies and touches no MicroShift-sensitive APIs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests were added or modified; the PR only updates a dependency and imports, so SNO compatibility is not impacted.
Topology-Aware Scheduling Compatibility ✅ Passed Commit only bumps go-health imports/module and vendored library files; no deployment manifests, controllers, or scheduling constraints were changed.
Ote Binary Stdout Contract ✅ Passed PASS: the PR only bumps go-health imports; vendored v2 has no init/Print stdout writes, and run.go already routes klog to stderr.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only updates go-health imports/module refs and vendor metadata.
No-Weak-Crypto ✅ Passed Diff only bumps go-health to v2 and renames imports; searches found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto in touched code.
Container-Privileges ✅ Passed Diff only updates go-health dependency/imports and vendored module metadata; no container/K8s manifest changes or privilege fields appear in the patch.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The PR only bumps imports/vendor code; logging lines are unchanged and no new log output includes secrets, PII, or hostnames.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skitt
Once this PR has been reviewed and has the lgtm label, please assign proietfb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen

Copy link
Copy Markdown
Member

/hold

Holding to allow the Kube rebase to land in #6321. Please ensure this will not cause merge conflicts for the Kube rebase before unholding this PR.

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 28, 2026
This is now a Go module.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
go.mod (1)

8-8: 🔒 Security & Privacy | 🔵 Trivial | 🏗️ Heavy lift

Track a replacement for the archived dependency.

v2.1.4 is the latest release, but the upstream repository was archived on December 23, 2024. Treat this as a temporary exception and link a migration issue with an owner before relying on it for future security fixes. (github.com)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 8, Add a temporary exception comment next to the
github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is
archived, and include a link to a migration issue with an assigned owner. Track
and reference the replacement plan while retaining version v2.1.4 until
migration is completed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@go.mod`:
- Line 8: Add a temporary exception comment next to the
github.com/InVisionApp/go-health/v2 dependency documenting that the upstream is
archived, and include a link to a migration issue with an assigned owner. Track
and reference the replacement plan while retaining version v2.1.4 until
migration is completed.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5039cc67-9981-4a9d-9906-9bf11f2ff6c1

📥 Commits

Reviewing files that changed from the base of the PR and between 777892a and ab3bbc2.

⛔ Files ignored due to path filters (16)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/InVisionApp/go-health/.travis.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/in-repo.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/CODEOWNERS is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/Makefile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/http.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/reachable.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/checkers/sql.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/health.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/in-repo.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/InVisionApp/go-health/v2/safe.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • cmd/apiserver-watcher/run.go
  • go.mod

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@skitt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit ab3bbc2 link true /test bootstrap-unit
ci/prow/unit ab3bbc2 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants