OCPBUGS-86429: Unpin libreswan and add 5.x compat for IPsec scaling fix

[anuragthehatter]

Summary

Backport libreswan 5.x compatibility changes to 4.18 to support unpinning libreswan from 4.6 to 5.x, mitigating IPsec scaling issues at 75+ node clusters.

Combines two changes already merged on main/4.19:

• CORENET-5524: Modify regex for ipsec showstates command #4959 (CORENET-5524): Update ipsec showstates regex from STATE_V2_ESTABLISHED_CHILD_SA to ESTABLISHED_CHILD_SA — libreswan 5.2 changed the state name format, shorter pattern is backward compatible with 4.x
• [release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections #5035 (OCPBUGS-55809): Use auto=start only for IPsec out connections (-out-1 suffix) to avoid cross-stream issue with libreswan 5.2. In connections use default auto=route

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

• openshift/os: unpin libreswan in RHCOS extensions
• openshift/machine-config-operator: this PR
• openshift/cluster-network-operator: skip _stackmanager for libreswan 5.3+
• openshift/ovn-kubernetes: unpin libreswan in Dockerfile

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@anuragthehatter: This pull request references Jira Issue OCPBUGS-55809, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead
• expected dependent Jira Issue OCPBUGS-55262 to target a version in 4.19.0, 4.19.z, but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CORENET-5524 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.z" version, but no target version was set.

Details

In response to this:

Summary

Backport libreswan 5.x compatibility changes to 4.18 to support unpinning libreswan from 4.6 to 5.x, mitigating IPsec scaling issues at 75+ node clusters.

Combines two changes already merged on main/4.19:

• CORENET-5524: Modify regex for ipsec showstates command #4959 (CORENET-5524): Update ipsec showstates regex from STATE_V2_ESTABLISHED_CHILD_SA to ESTABLISHED_CHILD_SA — libreswan 5.2 changed the state name format, shorter pattern is backward compatible with 4.x
• [release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections #5035 (OCPBUGS-55809): Use auto=start only for IPsec out connections (-out-1 suffix) to avoid cross-stream issue with libreswan 5.2. In connections use default auto=route

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

• openshift/os: unpin libreswan in RHCOS extensions
• openshift/machine-config-operator: this PR
• openshift/cluster-network-operator: skip _stackmanager for libreswan 5.3+
• openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2332672d-a1f2-4d80-b795-ea431f88430c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@anuragthehatter: This pull request references Jira Issue OCPBUGS-55809, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead
• expected dependent Jira Issue OCPBUGS-55262 to target a version in 4.19.0, 4.19.z, but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references CORENET-5524 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.z" version, but no target version was set.

Details

In response to this:

Summary

Backport libreswan 5.x compatibility changes to 4.18 to support unpinning libreswan from 4.6 to 5.x, mitigating IPsec scaling issues at 75+ node clusters.

Combines two changes already merged on main/4.19:

• CORENET-5524: Modify regex for ipsec showstates command #4959 (CORENET-5524): Update ipsec showstates regex from STATE_V2_ESTABLISHED_CHILD_SA to ESTABLISHED_CHILD_SA — libreswan 5.2 changed the state name format, shorter pattern is backward compatible with 4.x
• [release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections #5035 (OCPBUGS-55809): Use auto=start only for IPsec out connections (-out-1 suffix) to avoid cross-stream issue with libreswan 5.2. In connections use default auto=route

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

• openshift/os: unpin libreswan in RHCOS extensions
• openshift/machine-config-operator: this PR
• openshift/cluster-network-operator: skip _stackmanager for libreswan 5.3+
• openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign rishabhsaini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@anuragthehatter: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@anuragthehatter: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

Backport libreswan 5.x compatibility changes to 4.18 to support unpinning libreswan from 4.6 to 5.x, mitigating IPsec scaling issues at 75+ node clusters.

Combines two changes already merged on main/4.19:

• CORENET-5524: Modify regex for ipsec showstates command #4959 (CORENET-5524): Update ipsec showstates regex from STATE_V2_ESTABLISHED_CHILD_SA to ESTABLISHED_CHILD_SA — libreswan 5.2 changed the state name format, shorter pattern is backward compatible with 4.x
• [release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections #5035 (OCPBUGS-55809): Use auto=start only for IPsec out connections (-out-1 suffix) to avoid cross-stream issue with libreswan 5.2. In connections use default auto=route

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

• openshift/os: unpin libreswan in RHCOS extensions
• openshift/machine-config-operator: this PR
• openshift/cluster-network-operator: skip _stackmanager for libreswan 5.3+
• openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@anuragthehatter: This pull request references Jira Issue OCPBUGS-86429, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-86429 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport libreswan 5.x compatibility changes to 4.18 to support unpinning libreswan from 4.6 to 5.x, mitigating IPsec scaling issues at 75+ node clusters.

Combines two changes already merged on main/4.19:

• CORENET-5524: Modify regex for ipsec showstates command #4959 (CORENET-5524): Update ipsec showstates regex from STATE_V2_ESTABLISHED_CHILD_SA to ESTABLISHED_CHILD_SA — libreswan 5.2 changed the state name format, shorter pattern is backward compatible with 4.x
• [release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections #5035 (OCPBUGS-55809): Use auto=start only for IPsec out connections (-out-1 suffix) to avoid cross-stream issue with libreswan 5.2. In connections use default auto=route

Background

At 75+ node IPsec mesh scale, libreswan 4.6 pluto crashes with a segfault in set_larval_v2_transition() during concurrent Child SA negotiation, causing permanent tunnel failures. Libreswan 5.x fixes this. This PR is part of a set that unpins libreswan in 4.18.z:

• openshift/os: unpin libreswan in RHCOS extensions
• openshift/machine-config-operator: this PR
• openshift/cluster-network-operator: skip _stackmanager for libreswan 5.3+
• openshift/ovn-kubernetes: unpin libreswan in Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.