CNF-23391: mockgen deprecated: use uber-go/mock instead

[sebrandon1]

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#45

Summary by CodeRabbit

• Chores
  • Updated internal testing dependencies for improved development infrastructure and maintenance.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.60%. Comparing base (6c48650) to head (c90eb57).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files           5        5           
  Lines         244      244           
=======================================
  Hits          143      143           
  Misses         87       87           
  Partials       14       14           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sebrandon1]

/retest

[coderabbitai]

Walkthrough

The project switches its mocking framework dependency from github.com/golang/mock to go.uber.org/mock, updating the module requirement and corresponding test file imports to use the new package source.

Changes

Cohort / File(s)	Summary
Mock dependency migration go.mod, controllers/machineset_controller_test.go	Replaces github.com/golang/mock v1.6.0 with go.uber.org/mock v0.6.0 in module dependencies and updates the gomock import path in the test file accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description addresses the core change (deprecation and migration to maintained library) with context, but it doesn't follow the repository's template structure with required sections like 'What is being added', testing checklist, or manual testing steps.	Add the required sections from the template: explain the change in 'What is being added', complete the testing checklist, and provide manual testing steps or explain why none are needed.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in modified controllers/machineset_controller_test.go use static, descriptive strings without dynamic information or interpolation.
Test Structure And Quality	✅ Passed	This PR is a pure dependency migration from archived github.com/golang/mock to maintained go.uber.org/mock with no test logic changes.
Microshift Test Compatibility	✅ Passed	PR only updates mock library dependency from github.com/golang/mock to go.uber.org/mock with corresponding import changes; no new Ginkgo e2e tests added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only migrates mock library dependencies; no new Ginkgo e2e tests are being added.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only updates mock library dependencies in test files and go.mod; does not modify deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	This PR only updates the mock library dependency and does not introduce any new stdout writes in process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The custom check for IPv6 and disconnected network test compatibility applies only to new Ginkgo e2e tests. This PR only updates mock library imports and dependencies without adding any new tests.
Title check	✅ Passed	The title accurately reflects the main change: migrating from the deprecated github.com/golang/mock to go.uber.org/mock, which is the primary purpose of this PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign rbhilare for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-23391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#45

Summary by CodeRabbit

• Chores
• Updated internal testing dependencies for improved development infrastructure and maintenance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/validate	c90eb57	link	true	/test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.