Kubevirt datamover e2e#2174
Conversation
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
@kaovilai if needed we could increase the storage capacity of the test profile in openshift/release for the kubevirt job right? |
|
Not sure. But we can definitely have it use our own cluster which we can size how we want |
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
/retest |
| "aws", | ||
| "kubevirt", | ||
| "hypershift" | ||
| "kubevirt-datamover" |
There was a problem hiding this comment.
Missing comma after "hypershift", this is invalid JSON:
"hypershift"
"kubevirt-datamover"
Should be:
"hypershift",
"kubevirt-datamover"| } | ||
|
|
||
| if v != nil && wasInstalledFromTest { | ||
| v.EnsureVirtRemoval() |
There was a problem hiding this comment.
The EnsureVirtRemoval() call is now skipped ("leaving installation intact for reuse"). This makes sense for CI iteration speed, but it changes the cleanup behavior for local developer runs HCO, the community CatalogSource, CBT feature gates, and the kubevirt-hyperconverged namespace are all left on the cluster. Previous behavior tore everything down. Worth noting that in testing/dev docs so engineers know to clean up manually.
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
openshift-ci
Bot
added
the
approved
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weshayutin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
approved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weshayutin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
| return ocClient.Create(context.Background(), &backup) | ||
| } | ||
|
|
||
| func boolPtr(b bool) *bool { return &b } |
There was a problem hiding this comment.
please use https://pkg.go.dev/k8s.io/utils/pointer instead
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Why the changes were made
Need to start dev testing kubevirt-datamover in CI
TODO -
dataupload