test: rehearse LocalTagReferencePolicy fix for ci-tools images job#78460
test: rehearse LocalTagReferencePolicy fix for ci-tools images job#78460Prucek wants to merge 1 commit intoopenshift:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/pj-rehearse pull-ci-openshift-ci-tools-main-images |
|
@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
WalkthroughUpdates the container image reference in a CI/CD presubmit job configuration from an internal proxy image to a direct registry image ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-main-presubmits.yaml (1)
414-414: Pin the rehearsal image to an immutable digest.Line 414 uses a mutable
:latesttag withimagePullPolicy: Always, which allows repeated rehearsals to execute different binaries and undermines reproducibility of test results. Pin to an explicit digest for deterministic validation.Suggested change
- image: quay.io/prucek/ci-operator:latest + image: quay.io/prucek/ci-operator@sha256:fdfa14df985790ead5e3557490229dae044fc29c2d619eed1ae382d9fabaa9d3🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-main-presubmits.yaml` at line 414, The rehearsal job is using a mutable image tag ("image: quay.io/prucek/ci-operator:latest") with imagePullPolicy: Always which undermines reproducibility; update the image field to a pinned digest (e.g., "quay.io/prucek/ci-operator@sha256:...") for the rehearsal job and ensure any related imagePullPolicy remains appropriate, replacing the ":latest" reference in the job spec where "image: quay.io/prucek/ci-operator:latest" appears so the job always pulls the exact immutable artifact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-main-presubmits.yaml`:
- Line 414: The rehearsal job is using a mutable image tag ("image:
quay.io/prucek/ci-operator:latest") with imagePullPolicy: Always which
undermines reproducibility; update the image field to a pinned digest (e.g.,
"quay.io/prucek/ci-operator@sha256:...") for the rehearsal job and ensure any
related imagePullPolicy remains appropriate, replacing the ":latest" reference
in the job spec where "image: quay.io/prucek/ci-operator:latest" appears so the
job always pulls the exact immutable artifact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9db69fe6-376f-4cc5-9e94-c62759aa14ec
📒 Files selected for processing (1)
ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-main-presubmits.yaml
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-images |
|
@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-ci-tools-main-images |
|
@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Prucek: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
Summary
quay.io/prucek/ci-operator:latest) for thepull-ci-openshift-ci-tools-main-imagesjob to rehearse theLocalTagReferencePolicyfix from fix: use LocalTagReferencePolicy for input image tags ci-tools#5139SourcetoLocal, so builds pull base images from the internal registry instead of quay-proxy — avoiding "manifest unknown" failures when quay.io garbage-collects digestsThis PR is temporary and will be closed after rehearsal validates the fix.
🤖 Generated with Claude Code
Summary by CodeRabbit