CNTRLPLANE-3351: enable CPU resource request overrides for Azure self-managed e2e#78644
CNTRLPLANE-3351: enable CPU resource request overrides for Azure self-managed e2e#78644bryan-cox wants to merge 1 commit intoopenshift:mainfrom
Conversation
…-managed e2e Set E2E_RESOURCE_REQUEST_OVERRIDES=1 for the e2e-azure-self-managed job to activate CPU request overrides on control plane pods. This prevents the scheduler from over-packing hosted clusters onto management nodes, which causes CPU starvation and e2e test timeouts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@bryan-cox: This pull request references CNTRLPLANE-3351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis change introduces a new environment variable ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Sets
E2E_RESOURCE_REQUEST_OVERRIDES=1for thee2e-azure-self-managedjob to activate CPU request overrides on control plane pods. This prevents the scheduler from over-packing hosted clusters onto management nodes, which causes CPU starvation and e2e test timeouts.The env var is declared in the
hypershift-azure-run-e2e-self-managedstep ref and consumed by the Go test code inopenshift/hypershift(see openshift/hypershift#8385).Which issue(s) this PR fixes:
Fixes CNTRLPLANE-3351
Special notes for your reviewer:
E2E_RESOURCE_REQUEST_OVERRIDES=1in their env block are affectedChecklist:
Summary by CodeRabbit