[wmco] Add azure-e2e-operator-2machine CI job - #81847
Conversation
|
@ranjithrajaram, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughThe Windows E2E operator test now accepts a configurable Windows Machine replica count. Its default is one, while the Azure job sets it to two and passes that value to the E2E test entrypoint. ChangesWindows E2E replica configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @ranjithrajaram. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse |
jrvaldes
left a comment
jrvaldes
left a comment
There was a problem hiding this comment.
LGTM, left a minor recomendation
Add a WINDOWS_MACHINE_REPLICAS env var to the windows-e2e-operator-test step ref, allowing CI jobs to control how many Windows Machine instances are created. The default remains 1, preserving existing job behavior. Configure the existing azure-e2e-operator job with WINDOWS_MACHINE_REPLICAS=2 to enable E2E validation of the MaxParallelUpgrades constraint during userData-triggered Machine recreation, which requires at least 2 Machine-backed Windows nodes.
2508149 to
058b2a8
Compare
|
[REHEARSALNOTIFIER]
A total of 221 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Thanks for the recommendation |
|
@coderabbitai full review |
|
✅ Action performedFull review finished. |
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
/retest |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator |
|
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, ranjithrajaram The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 similar comments
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
vsphere-e2e-operator job but validated the param with 2 machines is not extending to others tests |
@ranjithrajaram see #81847 (comment) , no need to trigger other tests. Just need azure to pass. |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator Azure isntance deletion timed out, at 15 minutes |
|
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ranjithrajaram: job(s): either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jrvaldes Azure job is failing with the error " 2026/07/21 07:34:23 waiting (timeout: 5m0s) for 1 Windows Machines to reach phase "Provisioned" " should we adjust the timeout or consider this as an infra issue and do a retest ? |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ranjithrajaram: job(s): either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator |
|
@ranjithrajaram: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse-ok |
|
@mansikulkarni96: your |
|
/pj-rehearse auto-ack |
|
@mansikulkarni96: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ranjithrajaram: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Add a MACHINE_NODE_COUNT env var to the windows-e2e-operator-test step ref, allowing CI jobs to control how many Windows Machine instances are created. The default remains 1, preserving existing job behavior.
Add an azure-e2e-operator-2machine job variant for WMCO on master that sets MACHINE_NODE_COUNT=2. This enables E2E validation of the MaxParallelUpgrades constraint during userData-triggered Machine recreation, which requires at least 2 Machine-backed Windows nodes.
This is required for WMCO PR
openshift/windows-machine-config-operator#4155
Summary by CodeRabbit
windows-e2e-operator-testCI step reference to accept a newMACHINE_NODE_COUNTenvironment variable (defaulting to"1"), and forwards it to the E2E runner viahack/run-ci-e2e-test.sh -m.azure-e2e-operator-2machineWMCO job variant on themasterbranch that setsMACHINE_NODE_COUNT=2, enabling E2E coverage forMaxParallelUpgradesduring userData-triggered Machine recreation./pj-rehearse.