AUTOSCALE-892: CMA: Add PQC ML-KEM CI test by shyadav10 · Pull Request #82248 · openshift/release

shyadav10 · 2026-07-21T17:47:56Z

Jira link: https://redhat.atlassian.net/browse/AUTOSCALE-892

Summary by CodeRabbit

Updates the OpenShift CI configuration for the Custom Metrics Autoscaler (CMA) AWS OVN end-to-end workflow to add post-quantum (ML-KEM) verification using a TLS scanning step. The change introduces a new tls-scanner-tool base image definition, sets PQC_CHECK, SCAN_NAMESPACE, and TLS scanner resource limits (SCANNER_CPU, SCANNER_MEMORY) for the cma-e2e-aws-ovn job, and expands the E2E chain into explicit ordered refs so tls-scanner-run executes in the workflow before the existing cleanup/teardown steps.

coderabbitai · 2026-07-21T17:48:30Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 78959fdc-7178-4ed8-985f-edad06d05cbe

📥 Commits

Reviewing files that changed from the base of the PR and between c40b977 and 27e0e2c.

📒 Files selected for processing (1)

ci-operator/config/openshift/custom-metrics-autoscaler-operator/openshift-custom-metrics-autoscaler-operator-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift/custom-metrics-autoscaler-operator/openshift-custom-metrics-autoscaler-operator-main.yaml

Walkthrough

The OpenShift CI configuration adds a tls-scanner-tool base image and extends the AWS OVN CMA E2E workflow with scanner settings and an ordered tls-scanner-run step.

Changes

TLS scanner CI integration

Layer / File(s)	Summary
Define TLS scanner image `ci-operator/config/openshift/custom-metrics-autoscaler-operator/...yaml`	Adds the `tls-scanner-tool` base image definition.
Wire scanner into AWS OVN E2E `ci-operator/config/openshift/custom-metrics-autoscaler-operator/...yaml`	Adds PQC, namespace, and resource environment variables, and inserts `tls-scanner-run` into the ordered E2E chain before cleanup and teardown.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

openshift/release#82176: Adds the same TLS scanner image and AWS E2E workflow integration for another operator.
openshift/release#82313: Updates OpenShift CI base image lists in another operator pipeline.

Suggested labels: jira/valid-reference

Suggested reviewers: maxcao13, jkyros

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding a PQC ML-KEM CI test for CMA.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a ci-operator YAML changed; no Ginkgo test titles or test files were modified.
Test Structure And Quality	✅ Passed	Only a ci-operator YAML file changed; no Ginkgo test code or test blocks were modified, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	Only a ci-operator YAML was changed; no new Ginkgo e2e tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only CI YAML changed; it inserts an existing tls-scanner step, not new Ginkgo tests, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The change only edits ci-operator job config (env, ref chain, base image) and adds no affinity, selectors, replicas, or topology-aware scheduling logic.
Ote Binary Stdout Contract	✅ Passed	PR only changes ci-operator YAML; no process-level binary code or stdout writes were added, so the OTE stdout contract isn't implicated.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only updates CI workflow wiring to insert tls-scanner-run; no new Ginkgo tests or IPv4/public-internet assumptions were added.
No-Weak-Crypto	✅ Passed	Changed YAML adds an existing tls-scanner CI step; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code appears in the diff.
Container-Privileges	✅ Passed	The PR only edits CI step wiring/env in one YAML file; no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, SYS_ADMIN, or securityContext fields appear.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only updates CI env and step order; no passwords, tokens, PII, hostnames, or log statements are present.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)

ci-operator/config/openshift/custom-metrics-autoscaler-operator/openshift-custom-metrics-autoscaler-operator-main.yaml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

shyadav10 · 2026-07-21T18:09:53Z

/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-21T18:09:56Z

@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci-robot · 2026-07-21T18:16:04Z

@shyadav10: This pull request references AUTOSCALE-892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Jira link: https://redhat.atlassian.net/browse/AUTOSCALE-892

Summary by CodeRabbit

Updates OpenShift CI for the Custom Metrics Autoscaler to add a post-quantum cryptography ML-KEM test in the AWS OVN end-to-end workflow. The configuration adds the TLS scanner tool image, PQC scan settings, and a TLS scanner execution alongside the existing KEDA E2E tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

joelsmith · 2026-07-21T20:37:48Z

It looks like I was wrong about being able to just add the TLS test at the end of any existing E2E. That E2E's workflow seems to completely remove CMA when it is finished. Let's take a look at how else we might be able to do this. I prefer the idea of adding it to an existing E2E so that we don't need an entire cluster install just for this one test, so let's think about how that could work

shyadav10 · 2026-07-21T21:21:38Z

It looks like I was wrong about being able to just add the TLS test at the end of any existing E2E. That E2E's workflow seems to completely remove CMA when it is finished. Let's take a look at how else we might be able to do this. I prefer the idea of adding it to an existing E2E so that we don't need an entire cluster install just for this one test, so let's think about how that could work

What if we put the inline chain steps in the config, i.e replace - chain: keda-e2e-cma with the 6 individual step refs, and insert - ref: tls-scanner-run before - ref: keda-e2e-cma-teardown?

Something like this?
test:
-ref: keda-e2e-cma-install
-ref: keda-e2e-cma-apply-kc
-ref: keda-e2e-setup
-ref: keda-e2e-run
-ref: keda-e2e-clean
-ref: tls-scanner-run
-ref: keda-e2e-cma-teardown

joelsmith · 2026-07-21T21:49:36Z

I think that is a great idea, but I think we would need to move the tls test up one notch since I think the clean step does some of the keda removal

shyadav10 · 2026-07-22T05:29:12Z

/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-22T05:29:15Z

@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

shyadav10 · 2026-07-22T14:31:31Z

/retest

shyadav10 · 2026-07-22T14:31:46Z

/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-22T14:36:15Z

@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelsmith · 2026-07-22T16:32:33Z

Ugh, that KEDA test is way too flaky!
/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-22T16:32:37Z

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelsmith · 2026-07-22T19:26:49Z

Flaky test attempt number 3!
/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-22T19:26:52Z

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelsmith · 2026-07-22T20:58:06Z

Flaky test attempt number 3!

Oops, not flaky after all. I think it's broken. The E2Es are trying to remove the keda ns and install, but we are installing via the CMA operator. I think I figured out why.

I think we need to include the variables from https://github.com/openshift/release/blob/main/ci-operator/step-registry/keda/e2e/cma/keda-e2e-cma-chain.yaml#L11-L14 which are getting overwritten by our new env: so I think we need to merge the new vars with the vars from that chain.

Edit: I was right and wrong. We did need to add those, but my reasoning was wrong. We're not overwriting the chain, we're copying its important bits. Thanks for figuring it out despite my bad explanation.

shyadav10 · 2026-07-23T02:06:23Z

/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-23T02:06:25Z

@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-23T02:08:15Z

[REHEARSALNOTIFIER]
@shyadav10: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-custom-metrics-autoscaler-operator-main-ci-bundle-custom-metrics-autoscaler-operator-bundle	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-check-all-csv	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-gcp-ovn	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-verify-history	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-gofmt	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-govet	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-images	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-security	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

joelsmith · 2026-07-23T05:19:57Z

/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-23T05:20:00Z

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelsmith · 2026-07-23T05:38:22Z

This looks great, but I would like to see it pass once before merging. The last run seemed to be a flake of the KEDA tests, so hopefully this next run will pass. Once the rehearsal job passes, feel free to merge it. Thanks!
/lgtm
/approve

openshift-ci · 2026-07-23T05:38:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, shyadav10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/custom-metrics-autoscaler-operator/OWNERS~~ [joelsmith]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

joelsmith · 2026-07-23T06:23:16Z

/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

openshift-merge-bot · 2026-07-23T06:23:19Z

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

shyadav10 · 2026-07-23T15:11:24Z

/pj-rehearse ack

openshift-merge-bot · 2026-07-23T15:11:27Z

@shyadav10: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

* CMA: Add PQC ML-KEM CI test * restructured the test * changed env

CMA: Add PQC ML-KEM CI test

0d2d2a7

openshift-ci Bot requested review from jkyros and maxcao13 July 21, 2026 17:49

shyadav10 changed the title ~~CMA: Add PQC ML-KEM CI test~~ AUTOSCALE-892: CMA: Add PQC ML-KEM CI test Jul 21, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2026

restructured the test

c40b977

changed env

27e0e2c

openshift-ci Bot assigned joelsmith Jul 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 23, 2026

openshift-merge-bot Bot merged commit d5e33ea into openshift:main Jul 23, 2026
7 of 15 checks passed

apahim pushed a commit to apahim/release that referenced this pull request Jul 24, 2026

AUTOSCALE-892: CMA: Add PQC ML-KEM CI test (openshift#82248)

012dab6

* CMA: Add PQC ML-KEM CI test * restructured the test * changed env

coderabbitai Bot mentioned this pull request Jul 24, 2026

oran-o2ims: add tls scanner #82154

Open

mrniranjan pushed a commit to mrniranjan/release that referenced this pull request Jul 28, 2026

AUTOSCALE-892: CMA: Add PQC ML-KEM CI test (openshift#82248)

1213a70

* CMA: Add PQC ML-KEM CI test * restructured the test * changed env

Uh oh!

Conversation

shyadav10 commented Jul 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

shyadav10 commented Jul 21, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 21, 2026

Uh oh!

openshift-ci-robot commented Jul 21, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

joelsmith commented Jul 21, 2026

Uh oh!

shyadav10 commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joelsmith commented Jul 21, 2026

Uh oh!

shyadav10 commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

shyadav10 commented Jul 22, 2026

Uh oh!

shyadav10 commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

joelsmith commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

joelsmith commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

joelsmith commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shyadav10 commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

joelsmith commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

joelsmith commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

joelsmith commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

shyadav10 commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shyadav10 commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

openshift-ci-robot commented Jul 21, 2026 •

edited by atlassian Bot

Loading

shyadav10 commented Jul 21, 2026 •

edited

Loading

joelsmith commented Jul 22, 2026 •

edited

Loading