Skip to content

Add tls-scanner-run to RHOAI e2e job #82555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jul 29, 2026
+7 −0
Merged

Add tls-scanner-run to RHOAI e2e job #82555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ base_images:
name: "4.19"
namespace: origin
tag: operator-sdk
tls-scanner-tool:
name: "4.22"
namespace: ocp
tag: tls-scanner-tool
ubi:
name: ubi-minimal
namespace: ocp
Expand Down Expand Up @@ -121,6 +125,8 @@ tests:
SOURCE_IMAGE_REF: opendatahub-operator-rhoai
env:
IMAGE_REPO: opendatahub-operator
PQC_CHECK: "true"
SCAN_NAMESPACE: redhat-ods-operator,redhat-ods-applications
pre:
- ref: ipi-install-rbac
- ref: opendatahub-operator-e2e-cluster-preflight-health-check
Expand Down Expand Up @@ -152,6 +158,7 @@ tests:
cpu: 2000m
memory: 3Gi
timeout: 3h0m0s
- ref: tls-scanner-run

@coderabbitai coderabbitai Bot Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== locate target file =="
fd -a 'opendatahub-io-opendatahub-operator-main\.yaml$' . || true

echo "== target references =="
if [ -f ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml ]; then
  wc -l ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
  sed -n '140,175p' ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
fi

echo "== changed files/stat =="
git diff --stat || true
git diff -- ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml | sed -n '1,220p' || true

echo "== generated config status mentions =="
git ls-files ci-operator | sed -n '1,80p' | rg 'generated|metadata|config|jobs|Prow|Prow jobs|metadata' || true
rg -n "Generated|generated|Prow|make update|make registry-metadata|make ci-operator-config|make jobs|needs to|must be regenerated" README.md Makefile ci-operator/config 2>/dev/null | sed -n '1,220p' || true

Repository: openshift/release

Length of output: 37354

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== repository Makefile rules =="
if [ -f Makefile ]; then
  sed -n '/registry-metadata/ci-operator-config/jobs/update/p' Makefile | sed -n '1,240p' || true
  rg -n '^registry-metadata:|^ci-operator-config:|^jobs:|^update:' Makefile || true
fi

echo "== CI config related metadata files =="
rg -n "zz_generated_metadata|generated-metadata|metadata|prowing|Prow jobs|generated Prow jobs" ci-operator/config README.md Makefile 2>/dev/null || true

echo "== check whether target config has step in both diff and file =="
python3 - <<'PY'
from pathlib import Path
p=Path('ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml')
if p.exists():
    text=p.read_text()
    print('exists True')
    for i,line in enumerate(text.splitlines(),1):
        if 'tls-scanner-run' in line:
            print(f'{i}:{line.strip()}')
    print('total_lines', len(text.splitlines()))
else:
    print('exists False')
PY

Repository: openshift/release

Length of output: 50374

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== CI config related metadata files and generated artifacts =="
git ls-files | rg '(^ci-operator/config/.+/.*|Makefile|README\.md|zz_generated_metadata|generated.*metadata|.*Prow.*|.*jobs.*)' | sed -n '1,200p' || true

echo "== exact search for generated metadata/jobs wording =="
rg -n "generated metadata|zz_generated_metadata|Prow jobs|generated Prow|make update|make registry-metadata|make ci-operator-config|make jobs" . \
  -g 'Makefile' -g 'README.md' -g '*ci-operator*' -g '*generated*' -g '*.yaml' -g '*.yml' | sed -n '1,240p' || true

echo "== diff around exact target line with context =="
git diff -- ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml | sed -n '1,260p' || true

Repository: openshift/release

Length of output: 47231

Validate generated CI artifacts for the new scan step.

This CI job has been modified, so regenerate/generate the derived CI metadata and Prow jobs before merging.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml`
at line 161, Regenerate the derived CI metadata and Prow job artifacts after
adding the tls-scanner-run step to the CI configuration, ensuring the generated
outputs reflect the updated job definition before merging.

Sources: Coding guidelines, Learnings

workflow: generic-claim
- as: opendatahub-operator-image-mirror
postsubmit: true
Expand Down