AGENT-1569: run IRI deletion tests

[pawanpinjarkar]

This patch adds the IRI deletion e2e tests to the iso-no-registry job for 4.22 similar to #79305

Summary by CodeRabbit

• Updates the OpenShift Machine Config Operator 4.22 iso-no-registry CI job (e2e-agent-compact-ipv4-iso-no-registry) to run IRI end-to-end deletion tests in addition to the existing IRI tests by invoking make test-e2e-iri with TAGS=iri_delete.
• Wraps the test commands in a multi-line Bash script with strict execution enabled (set -xeuo pipefail) to fail fast on errors and unset variables.

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-1517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This patch adds the IRI deletion e2e tests to the iso-no-registry job for 4.22 similar to #79305

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/cc @andfasano @bfournie

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2514c0e8-4a7e-442b-85d8-2590b295c2fc

📥 Commits

Reviewing files that changed from the base of the PR and between 6075717 and 62f2b5a.

📒 Files selected for processing (1)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22.yaml

---

Walkthrough

The release 4.22 machine-config-operator test job now runs the standard IRI end-to-end test followed by the iri_delete-tagged test under strict Bash execution.

Changes

IRI E2E tests

Layer / File(s)	Summary
IRI test command sequence ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22.yaml	The test step enables set -xeuo pipefail, runs make test-e2e-iri, and then reruns it with TAGS=iri_delete.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: andfasano, bfournie, sergiordlr

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding IRI deletion tests to the job.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a CI job command block changed; no Ginkgo titles were added or modified, and no dynamic names appear in the diff.
Test Structure And Quality	✅ Passed	PR only changes a ci-operator YAML job command; no Ginkgo test code, It blocks, or assertions are modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	PR only changes ci-operator job commands; no Ginkgo test code or new test names were added, so MicroShift compatibility isn't implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only the ci-operator job command changed; no new Ginkgo e2e test definitions were added, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a ci-operator test command changed; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	The PR only changes CI YAML to add a shell command step; no process-level Go/test code or stdout-writing setup was introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo test code was added; the PR only changes CI commands, and the touched stanza has no IPv4 literals or external hosts.
No-Weak-Crypto	✅ Passed	The only changed stanza adds bash commands to run e2e tests; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges	✅ Passed	No privileged pod/container settings were added; the diff only changes test commands, and the job stanza lacks privileged/hostPID/hostNetwork/allowPrivilegeEscalation flags.
No-Sensitive-Data-In-Logs	✅ Passed	The changed CI script only logs generic bash/make commands; it contains no passwords, tokens, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign yuqi-zhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andfasano]

/hold

Requires openshift/machine-config-operator#6323

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-1569 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This patch adds the IRI deletion e2e tests to the iso-no-registry job for 4.22 similar to #79305

Summary by CodeRabbit

• Updates the OpenShift Machine Config Operator 4.22 iso-no-registry CI job to run IRI deletion end-to-end tests in addition to the existing IRI tests.
• Enables strict Bash execution for the test commands.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-config-operator-release-4.22-e2e-agent-compact-ipv4-iso-no-registry	openshift/machine-config-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.