WINC-1992: React to 1.36 kube rebase - #4378
Conversation
Update to openshift/ovn-kubernetes@4c92603 This commit was generated using hack/update_submodules.sh
Update to openshift/kubernetes@a80dac2 This commit was generated using hack/update_submodules.sh
This commit was generated using hack/update_submodules.sh
This commit was generated using hack/update_submodules.sh
Update to openshift/cloud-provider-azure@f2af9b4 This commit was generated using hack/update_submodules.sh
Update to openshift/cloud-provider-aws@278e8c0 This commit was generated using hack/update_submodules.sh
This commit uses the proper constant format string "%s" with err.Error() as the argument to satisfy the go vet printf check added in client-go v0.36.x.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@jrvaldes: This pull request references WINC-1992 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThe operator’s minimum Kubernetes version and validation tests move from 1.35 to 1.36. Go dependencies and Kubernetes-related modules are refreshed, while kubelet, cloud-provider, and OVN references advance to newer revisions. The Makefile kubelet revision is aligned with the updated kubelet source. Node reconciliation warning events now pass errors through an explicit format string. Suggested reviewers: 🚥 Pre-merge checks | ✅ 20✅ Passed checks (20 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test ? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test aws-e2e-operator |
openshift-ci
Bot
added
the
approved
|
/test lint |
|
/test unit |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
/retest |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pkg/cluster/config_test.go (1)
128-130: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the new upper Kubernetes version boundary.
The validator now accepts
v1.36.xthroughv1.37.x, but these cases only exercise the lower boundary and an out-of-rangev1.38.2. Add explicitv1.37.xacceptance andv1.38.0rejection cases so regressions inmaxK8sVersionare caught.Suggested test cases
+ {"cluster version immediately below supported version", "v1.35.4", true}, {"cluster version equals supported version", "v1.36.0", false}, {"cluster version equals supported version", "v1.36.4", false}, + {"cluster version at upper supported version", "v1.37.4", false}, + {"cluster version immediately above supported version", "v1.38.0", true},🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/cluster/config_test.go` around lines 128 - 130, Extend the version table in the cluster version validation tests to cover the upper boundary: add accepted v1.37.x cases and an explicitly rejected v1.38.0 case. Keep the existing lower-boundary and v1.38.2 cases unchanged, using the same test structure and validator exercised by the surrounding cases.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 130: Update the google.golang.org/grpc dependency from v1.79.3 to v1.82.1
or newer, then regenerate the module graph so go.mod and go.sum reflect the
patched release and its resolved dependencies.
---
Nitpick comments:
In `@pkg/cluster/config_test.go`:
- Around line 128-130: Extend the version table in the cluster version
validation tests to cover the upper boundary: add accepted v1.37.x cases and an
explicitly rejected v1.38.0 case. Keep the existing lower-boundary and v1.38.2
cases unchanged, using the same test structure and validator exercised by the
surrounding cases.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
/lgtm |
|
/retest-required |
|
/override ci/prow/vsphere-disconnected-e2e-operator |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/vsphere-disconnected-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rrasouli please investigate aws-e2e-ote — Job failed. |
@jrvaldes 5/5 failed tests, after batch2 merged we can verify that change is working properly (SSH fix) |
|
/override ci/prow/aws-e2e-ote |
|
/override ci/prow/platform-none-vsphere-e2e-operator |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/aws-e2e-ote DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/platform-none-vsphere-e2e-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-disconnected-e2e-operator ci/prow/vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/images ci/prow/lint ci/prow/security ci/prow/unit ci/prow/wicd-unit-vsphere ci/prow/ci-bundle-wmco-bundle |
|
no need to retest, diff is just ubi image bump |
|
@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/aws-e2e-operator, ci/prow/azure-e2e-operator, ci/prow/azure-e2e-upgrade, ci/prow/ci-bundle-wmco-bundle, ci/prow/gcp-e2e-operator, ci/prow/images, ci/prow/lint, ci/prow/nutanix-e2e-operator, ci/prow/platform-none-vsphere-e2e-operator, ci/prow/security, ci/prow/unit, ci/prow/vsphere-disconnected-e2e-operator, ci/prow/vsphere-e2e-operator, ci/prow/vsphere-proxy-e2e-operator, ci/prow/wicd-unit-vsphere DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jrvaldes: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Summary by CodeRabbit
New Features
Updates
Bug Fixes