Skip to content

WINC-2015: [hack] Run creation tests in setup-only mode - #4388

Draft
rrasouli wants to merge 1 commit into
openshift:masterfrom
rrasouli:winc-2015-setup-only-fix
Draft

WINC-2015: [hack] Run creation tests in setup-only mode#4388
rrasouli wants to merge 1 commit into
openshift:masterfrom
rrasouli:winc-2015-setup-only-fix

Conversation

@rrasouli

@rrasouli rrasouli commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

The setup-only mode in hack/run-ci-e2e-test.sh exits before running any e2e tests, including the creation tests that provision the cloud-private-key secret and Windows MachineSets. This causes the aws-e2e-ote CI job to run OTE extension tests on a cluster with zero Windows nodes, failing all 5 tests that require them.

This moves the setup-only exit to after the creation tests so that:

  • WMCO is installed (existing behavior)
  • TestWMCO/create runs: creates cloud-private-key secret, applies MachineSet, waits for Windows nodes
  • Exit before basic, upgrade, and deletion tests (still skipped)

The subsequent OTE test step finds Ready Windows nodes on the cluster.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 31, 2026

Copy link
Copy Markdown

@rrasouli: This pull request references WINC-2015 which is a valid jira issue.

Details

In response to this:

Summary

The setup-only mode in hack/run-ci-e2e-test.sh exits immediately after installing WMCO, skipping the creation tests that provision the cloud-private-key secret and Windows MachineSets. This causes the aws-e2e-ote CI job to run OTE extension tests on a cluster with zero Windows nodes, failing all 5 tests that require them.

This removes the early exit so setup-only runs:

  • Operator validation (without secret)
  • Creation tests (provisions Windows nodes)
  • Skips basic, upgrade, and deletion tests (existing conditions handle this)

With -s flag, nodes persist for the subsequent OTE test step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (2)
  • do-not-merge/work-in-progress
  • do-not-merge/hold

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: dfc6f8b4-f928-4e0b-902d-a1e50a8edb71

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rrasouli
rrasouli force-pushed the winc-2015-setup-only-fix branch 2 times, most recently from 8d18b16 to b6ae8c9 Compare July 31, 2026 08:14
The setup-only mode exits before running any e2e tests, including the
creation tests that provision the cloud-private-key secret and Windows
MachineSets. This causes the aws-e2e-ote CI job to run OTE tests on a
cluster with no Windows nodes, failing all tests that require them.

Move the setup-only exit to after the creation tests so that Windows
nodes are provisioned before exiting. The remaining e2e tests (basic,
upgrade, deletion) are still skipped.
@rrasouli
rrasouli force-pushed the winc-2015-setup-only-fix branch from b6ae8c9 to 621d8c9 Compare July 31, 2026 08:16

@jrvaldes jrvaldes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jrvaldes jrvaldes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, rrasouli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants