WINC-2015: [hack] Run creation tests in setup-only mode - #4388
Conversation
|
@rrasouli: This pull request references WINC-2015 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8d18b16 to
b6ae8c9
Compare
The setup-only mode exits before running any e2e tests, including the creation tests that provision the cloud-private-key secret and Windows MachineSets. This causes the aws-e2e-ote CI job to run OTE tests on a cluster with no Windows nodes, failing all tests that require them. Move the setup-only exit to after the creation tests so that Windows nodes are provisioned before exiting. The remaining e2e tests (basic, upgrade, deletion) are still skipped.
b6ae8c9 to
621d8c9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, rrasouli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
The setup-only mode in hack/run-ci-e2e-test.sh exits before running any e2e tests, including the creation tests that provision the cloud-private-key secret and Windows MachineSets. This causes the aws-e2e-ote CI job to run OTE extension tests on a cluster with zero Windows nodes, failing all 5 tests that require them.
This moves the setup-only exit to after the creation tests so that:
The subsequent OTE test step finds Ready Windows nodes on the cluster.