Add getNetworkRegisteredBlock view to SubnetPrecompile#2674
Open
fine135 wants to merge 1 commit into
Open
Conversation
open-junius
approved these changes
May 20, 2026
Contributor
|
Thanks for the contribution. I will scan all view functions defined in precompiles, record the cost of reading data from storage. |
l0r1s
requested changes
May 20, 2026
| string memory additional | ||
| ) external payable; | ||
| function getServingRateLimit(uint16 netuid) external view returns (uint64); | ||
| function getNetworkRegisteredBlock(uint16 netuid) external view returns (uint64); |
Collaborator
There was a problem hiding this comment.
Can we have the name getNetworkRegisteredAt to map the actual storage name? Or eventually getNetworkRegistrationBlock if we want to decouple it from storage name? It reads better imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
getNetworkRegisteredBlock(uint16)as a view function toSubnetPrecompile, allowing smart contracts to query the block number at which a given subnet was registered. The function reads directly fromNetworkRegisteredAtstorage and explicitly recordsdb_read_gas_costso callers are correctly charged when invoked from within a contract.Also adds the corresponding ABI entry to
contract-tests/src/contracts/subnet.tsand an e2e test incontract-tests/test/precompileWrapper.direct-call.test.ts.Related Issue(s)
Type of Change
Breaking Change
N/A
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
N/A
Additional Notes
The function follows the same pattern as other view functions in
SubnetPrecompile(e.g.getServingRateLimit), with the addition of explicit gas metering viahandle.record_cost(RuntimeHelper::<R>::db_read_gas_cost())- unlike the existing view functions which omit this.