Support real-pays-fee through three proxy levels#2679
Open
edpoptart wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
ChargeTransactionPaymentWrapperfee-payer resolution forRealPaysFeeproxy calls to support a bounded proxy chain of up to three proxy levels.This also supports homogeneous
batch,batch_all, andforce_batchcalls at the innermost supported level, while preserving the existing fallback where batches containing mixed real accounts are charged to the original signer.The transaction priority behavior remains unchanged.
Related Issue(s)
Type of Change
Breaking Change
N/A
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
N/A
Additional Notes
Validation performed:
./scripts/fix_rust.shcompletedcargo check,cargo clippy --fix,cargo fix, andcargo fmtcargo test -p node-subtensor-runtime --test transaction_payment_wrapperpassed with 25 tests.git diff --checkpassed.The failing checks appear unrelated to this change:
cargo auditis failing on existing yanked dependencies (core2 0.4.0,keccak 0.1.5).Try Runtime / check testnetfails inmigrate_fix_total_issuance_evm_feeswithTotalIssuance diff greater than allowable delta;finneyanddevnetpassed.Validate-Benchmarksgenerated the standard benchmark patch artifact and suggests applying theapply-benchmark-patchlabel.This PR only changes
ChargeTransactionPaymentWrapperfee-payer resolution/tests/docs and does not touch dependencies, migrations, or pallet benchmarked extrinsics.