Phonetic Assistant Improvements - #2335
Open
maiko3tattun wants to merge 2 commits into
Open
Conversation
Cadlaxa
self-requested a review
September 1, 2026 06:50
Member
|
tested this on non japanese vb, it works great |
Cadlaxa
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Before: Only full aliases were displayed in the suggested lyric list.
After: The system now suggests Phonetic first, followed by full aliases. (Note: Phonetic suggestions are only included in the suggested lyric list and are not part of the suggested alias list.)
Example: When typing "a" to find "- あ", previously only the full alias including the suffix (e.g., "- あ_A3") was shown. Now, "- あ" (Phonetic) will be suggested even if it is not explicitly listed in the oto list.
Note: