Fix NaN envelope when oto preutter is zero - #2350
Merged
Merged
Conversation
Singers with dummy otos (VOICEVOX, ENUNU, DiffSinger, Vogen) and UTAU otos with a blank preutter leave autoPreutter at 0. When the previous phoneme is shorter than 5ms, maxPreutter goes negative and ValidateOverlap computes maxPreutter / autoPreutter = -Infinity, so autoOverlap becomes NaN. That NaN reaches the previous phoneme's envelope p3/p4 via tailIntrude/tailOverlap, and PhonemeCanvas.Render crashes feeding it to TimeAxis.MsPosToTickPos. Scale autoOverlap only when there is a preutter to scale against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singers with dummy otos (VOICEVOX, ENUNU, DiffSinger, Vogen) and UTAU otos with a blank preutter leave autoPreutter at 0. When the previous phoneme is shorter than 5ms, maxPreutter goes negative and ValidateOverlap computes maxPreutter / autoPreutter = -Infinity, so autoOverlap becomes NaN. That NaN reaches the previous phoneme's envelope p3/p4 via tailIntrude/tailOverlap, and PhonemeCanvas.Render crashes feeding it to TimeAxis.MsPosToTickPos.
Scale autoOverlap only when there is a preutter to scale against.