Skip to content

treewide: remove packages moved to openwrt/packages - #1198

Merged
BKPepe merged 11 commits into
openwrt:masterfrom
BKPepe:drop-migrated-packages
Aug 11, 2026
Merged

treewide: remove packages moved to openwrt/packages#1198
BKPepe merged 11 commits into
openwrt:masterfrom
BKPepe:drop-migrated-packages

Conversation

@BKPepe

@BKPepe BKPepe commented Aug 6, 2026

Copy link
Copy Markdown
Member

Removes the packages which are being moved to openwrt/packages, as discussed in #184 — one removal commit per package.

Do not merge yet — this is the coordinated second step. Each removal commit references its counterpart PR in openwrt/packages:

Package openwrt/packages PR
alfred openwrt/packages#30161
babeld openwrt/packages#30162
batctl openwrt/packages#30163
batman-adv openwrt/packages#30164
bird2 openwrt/packages#30165
bird3 openwrt/packages#30166
bmx7 openwrt/packages#30167
mesh11sd openwrt/packages#30168
nodogsplash openwrt/packages#30169
olsrd openwrt/packages#30170
opennds openwrt/packages#30171

The PR will be marked ready once the packages side is merged, so the two feeds do not ship duplicate packages longer than necessary. If only a subset gets merged over there, the corresponding subset of commits can be cherry-picked instead.

@openwrt openwrt Bot added the drop package Removes an existing package Makefile from the tracking tree label Aug 6, 2026
BKPepe and others added 11 commits August 11, 2026 13:30
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30161.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30162.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30163.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30164.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30165.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30166.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30167.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30168.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30169.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30170.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as
discussed in openwrt#184.

See openwrt/packages#30171.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@BKPepe
BKPepe force-pushed the drop-migrated-packages branch from 886d64e to 4b9891b Compare August 11, 2026 11:31
@BKPepe

BKPepe commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Gentlemen, this has been sitting here for five days and I need it to move.

The situation: openwrt/packages has the openwrt-bot enabled, sponsored by Anthropic, which gives us Claude reviews there, and it has found real bugs in these packages, including a command injection in olsrd-neigh.sh and a build failure of batman-adv on every 6.12 target.

The problem is that some of those bugs are already in the stable branches, and some of them I would like to backport there. Right now we have pull requests open both here and in openwrt/packages for the same packages, and every fix has to be duplicated across the two. That is a road to hell.

So: I am removing these packages as they are, and the rest gets sorted out in openwrt/packages.

What happens to the work already in flight:

  • The fixes already merged here (1192, 1193, 1196) stay in master until this lands, and are already carried in the corresponding openwrt/packages PRs.
  • The remaining six (1190, 1191, 1194, 1195, 1197, 1199) have been retargeted to openwrt-25.12, since that is where these packages still need to live.
  • The eleven openwrt/packages PRs from 30161 to 30171 carry the same packages with the review fixes applied.

Heads-up: @tohojo @simonwunderlich @PolynomialDivision @bluewavenet @axn @mwarning @ecsv, this removes the packages you maintain from this feed. Nothing is lost. Each one has an open PR in openwrt/packages.

@BKPepe
BKPepe marked this pull request as ready for review August 11, 2026 11:35
Copilot AI lite review requested due to automatic review settings August 11, 2026 11:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@BKPepe
BKPepe merged commit 4b9891b into openwrt:master Aug 11, 2026
4 checks passed
@DamisDorgon

Copy link
Copy Markdown

Why not one at a time, as they are merged into the packages feed?

@BKPepe

BKPepe commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Look, I think I described it well above in that slightly longer text. Unfortunately, there was no other way to do it. I really can't wait around here for someone to get to it after a month, then I'd have to go through it all over again and figure out what it was actually about.

If I wait, I could be waiting forever. As you noticed, things were getting duplicated, and yes, a snapshot can simply be broken. Reviewing it here in openwrt/routing and openwrt/packages made no sense. If you just want the package you were using to reappear in the feed, you obviously use it, so you can check out the discussion in that repository and help the package maintainer get it back into the feed.

The transition from openwrt/routing to openwrt/packages has been in the works for over 10 years. So there was plenty of time.

@ecsv

ecsv commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

If you just want the package you were using to reappear in the feed, you obviously use it, so you can check out the discussion in that repository and help the package maintainer get it back into the feed.

The transition from openwrt/routing to openwrt/packages has been in the works for over 10 years. So there was plenty of time.

NOT ABOUT THE REMOVAL: I think there is a problem here regarding the communication. There is always "this is the goal somewhere far in the future" or a lot of "i am against this specific thing". But the "what is expected by the maintainers" and "what should be done by what person next" part might be improved. It is most likely clear for you - but we are not in your head.

You are talking here about "help the package maintainer get it back into the feed.". From the outside perspective, it just looks to us like you decided that you want to continue this process by yourself (which is absolutely fine by me). But it is absolutely not clear to me what the maintainers should do now. You are specifically saying here "package maintainer get it back into the feed" - which implies that you expect other people (maintainers) to do something(tm). But what is the something(tm) when you took over the task and didn't mention in the PRs what is expected by the maintainers? The PRs say "The content matches the current routing feed master." - which would imply that the maintainer already reviewed or wrote this (a long time ago) and doesn't need to re-review it again. And I would also guess no maintainer will now oppose this PR because then the maintained package would be gone for good (as it is currently in openwrt/routing).

I think many might not even have write access to openwrt/packages and are therefore relying on persons like you to merge the PRs. I could be wrong about the last part because there was some discussion in #184 about granting the routing-maintainers (which maybe not even existing yet) access to openwrt/packages - but there were also other voices (like you) which were against granting access to them. I have therefore not idea what the situation is there.

@simonwunderlich do you have commit access to openwrt/packages or did you get some information what is expected from you regarding the alfred/batct/batman-adv PRs?

And regarding the removal: I think part from the confusion stems from the fact that the openwrt/packages PRs still state

The content matches the current routing feed master. Once this is merged, the package will be removed from the routing feed (a coordinated removal PR is prepared there).

Which is obviously not true anymore but was forgotten to be updated. Not a big problem but I've just noticed it.

@simonwunderlich

Copy link
Copy Markdown
Contributor

@ecsv I don't have write/commit access to this repo (but I have/had to routing-packages). I don't think that I got instructions/expectations how to help with this migration, but I was on vacation and there were lots of e-mails in this time ... I've seen this "plan" for years, though.

Either way, I appreciate the push now, please let me know if there is something I can help with. At least with merging the changes I can't really help, unless someone grants me access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drop package Removes an existing package Makefile from the tracking tree

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants