treewide: remove packages moved to openwrt/packages - #1198
Conversation
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30161. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30162. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30163. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30164. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30165. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30166. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30167. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30168. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30169. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30170. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
The package has been moved to the openwrt/packages feed, as discussed in openwrt#184. See openwrt/packages#30171. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
886d64e to
4b9891b
Compare
|
Gentlemen, this has been sitting here for five days and I need it to move. The situation: openwrt/packages has the openwrt-bot enabled, sponsored by Anthropic, which gives us Claude reviews there, and it has found real bugs in these packages, including a command injection in The problem is that some of those bugs are already in the stable branches, and some of them I would like to backport there. Right now we have pull requests open both here and in openwrt/packages for the same packages, and every fix has to be duplicated across the two. That is a road to hell. So: I am removing these packages as they are, and the rest gets sorted out in openwrt/packages. What happens to the work already in flight:
Heads-up: @tohojo @simonwunderlich @PolynomialDivision @bluewavenet @axn @mwarning @ecsv, this removes the packages you maintain from this feed. Nothing is lost. Each one has an open PR in openwrt/packages. |
|
Why not one at a time, as they are merged into the packages feed? |
|
Look, I think I described it well above in that slightly longer text. Unfortunately, there was no other way to do it. I really can't wait around here for someone to get to it after a month, then I'd have to go through it all over again and figure out what it was actually about. If I wait, I could be waiting forever. As you noticed, things were getting duplicated, and yes, a snapshot can simply be broken. Reviewing it here in openwrt/routing and openwrt/packages made no sense. If you just want the package you were using to reappear in the feed, you obviously use it, so you can check out the discussion in that repository and help the package maintainer get it back into the feed. The transition from openwrt/routing to openwrt/packages has been in the works for over 10 years. So there was plenty of time. |
NOT ABOUT THE REMOVAL: I think there is a problem here regarding the communication. There is always "this is the goal somewhere far in the future" or a lot of "i am against this specific thing". But the "what is expected by the maintainers" and "what should be done by what person next" part might be improved. It is most likely clear for you - but we are not in your head. You are talking here about "help the package maintainer get it back into the feed.". From the outside perspective, it just looks to us like you decided that you want to continue this process by yourself (which is absolutely fine by me). But it is absolutely not clear to me what the maintainers should do now. You are specifically saying here "package maintainer get it back into the feed" - which implies that you expect other people (maintainers) to do something(tm). But what is the something(tm) when you took over the task and didn't mention in the PRs what is expected by the maintainers? The PRs say "The content matches the current routing feed master." - which would imply that the maintainer already reviewed or wrote this (a long time ago) and doesn't need to re-review it again. And I would also guess no maintainer will now oppose this PR because then the maintained package would be gone for good (as it is currently in openwrt/routing). I think many might not even have write access to openwrt/packages and are therefore relying on persons like you to merge the PRs. I could be wrong about the last part because there was some discussion in #184 about granting the @simonwunderlich do you have commit access to openwrt/packages or did you get some information what is expected from you regarding the alfred/batct/batman-adv PRs? And regarding the removal: I think part from the confusion stems from the fact that the openwrt/packages PRs still state
Which is obviously not true anymore but was forgotten to be updated. Not a big problem but I've just noticed it. |
|
@ecsv I don't have write/commit access to this repo (but I have/had to routing-packages). I don't think that I got instructions/expectations how to help with this migration, but I was on vacation and there were lots of e-mails in this time ... I've seen this "plan" for years, though. Either way, I appreciate the push now, please let me know if there is something I can help with. At least with merging the changes I can't really help, unless someone grants me access. |
Removes the packages which are being moved to openwrt/packages, as discussed in #184 — one removal commit per package.
Do not merge yet — this is the coordinated second step. Each removal commit references its counterpart PR in openwrt/packages:
The PR will be marked ready once the packages side is merged, so the two feeds do not ship duplicate packages longer than necessary. If only a subset gets merged over there, the corresponding subset of commits can be cherry-picked instead.