Skip to content

fix: avoid invalid secret checks in release workflow - #18

Merged
orangeboyChen merged 1 commit into
mainfrom
codex/fix-release-workflow-dockerhub
Jul 11, 2026
Merged

fix: avoid invalid secret checks in release workflow#18
orangeboyChen merged 1 commit into
mainfrom
codex/fix-release-workflow-dockerhub

Conversation

@orangeboyChen

Copy link
Copy Markdown
Owner

Summary

  • repair the release workflow so GitHub Actions accepts the file again
  • detect Docker Hub credentials in a shell step and gate Docker Hub login from that output
  • keep the existing behavior of pushing latest/version tags to GHCR and optionally to Docker Hub

Root cause

Verification

  • bun run lint
  • bun run format:check
  • bun run typecheck
  • bun run test:coverage
  • bun run build

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.74%. Comparing base (609c9dd) to head (9ec1ac8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files          12       12           
  Lines        4770     4770           
  Branches      978      978           
=======================================
  Hits         4376     4376           
  Misses        385      385           
  Partials        9        9           
Flag Coverage Δ
unittests 91.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orangeboyChen
orangeboyChen marked this pull request as ready for review July 11, 2026 04:13
@orangeboyChen
orangeboyChen merged commit a7d7103 into main Jul 11, 2026
5 checks passed
@orangeboyChen
orangeboyChen deleted the codex/fix-release-workflow-dockerhub branch July 11, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants